Closed Bug 647322 Opened 13 years ago Closed 13 years ago

Port |Bug 640649 - Remove unused cmd_file| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1final

People

(Reporter: sgautherie, Assigned: ewong)

References

()

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Flags: in-testsuite-
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/resources/content/mailWindowOverlay.xul&rev=1.89

> 1.89 <mscott@netscape.com> 2001-03-16 17:57
> Land the Mailnews Performance Branch.
> Includes front end re-write to use the outliner widget for the thread pane.
> 
> Improvements in scrolling, folder loading, message display, replyto time, sorting, selecting, deleting, the list goes
> on and on.
> 
> enjoy =).

Eeek. 11 years ago mscott removed the observer but didn't remove the observed command.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached patch Ported |Bug 640649| to SeaMonkey (obsolete) — Splinter Review
Attachment #523782 - Flags: review?(mnyromyr)
Comment on attachment 523782 [details] [diff] [review]
Ported |Bug 640649| to SeaMonkey

Comparing with bug 640649 changeset,

>-        return GetNumSelectedMessages() > 0;

I agree this would make SM more like TB.
But you should search history and explain whether/why we want that change too.

>-        return (gCurrentMessageUri != null);

TB still has this line.
I assume it should not be removed, not without explanation.
Attachment #523782 - Flags: feedback-
Attachment #523782 - Attachment is obsolete: true
Attachment #523782 - Flags: review?(mnyromyr)
Attachment #524612 - Flags: review?(mnyromyr)
Attachment #524612 - Flags: feedback+
Attachment #524612 - Flags: superreview+
Attachment #524612 - Flags: review?(mnyromyr)
Attachment #524612 - Flags: review+
Comment on attachment 524612 [details] [diff] [review]
Port |bug 640649 - Removed unused cmd_file| to SeaMonkey (v2)
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/c4fd9ad67939
Attachment #524612 - Attachment description: Port |bug 640649 - Removed unused cmd_file| to SeaMonkey (v2) → Port |bug 640649 - Removed unused cmd_file| to SeaMonkey (v2) [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → seamonkey2.1final
(In reply to comment #4)
> >-        return GetNumSelectedMessages() > 0;
> 
> I agree this would make SM more like TB.
> But you should search history and explain whether/why we want that change too.

I filed (TB) bug 650703, fwiw.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: