647322 - Port |Bug 640649 - Remove unused cmd_file| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

"Found 5 matching lines in 3 files"

Comment 2

[Philip Chee]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/resources/content/mailWindowOverlay.xul&rev=1.89

> 1.89 <[e-mail]> 2001-03-16 17:57
> Land the Mailnews Performance Branch.
> Includes front end re-write to use the outliner widget for the thread pane.
> 
> Improvements in scrolling, folder loading, message display, replyto time, sorting, selecting, deleting, the list goes
> on and on.
> 
> enjoy =).

Eeek. 11 years ago mscott removed the observer but didn't remove the observed command.

Comment 3

[Edmund Wong (:ewong)]

Attachment: Ported |Bug 640649| to SeaMonkey

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 523782 [details] [diff] [review]
Ported |Bug 640649| to SeaMonkey

Comparing with bug 640649 changeset,

>-        return GetNumSelectedMessages() > 0;

I agree this would make SM more like TB.
But you should search history and explain whether/why we want that change too.

>-        return (gCurrentMessageUri != null);

TB still has this line.
I assume it should not be removed, not without explanation.

Comment 5

[Edmund Wong (:ewong)]

Attachment: Port |bug 640649 - Removed unused cmd_file| to SeaMonkey (v2) [Checked in: Comment 6]

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 524612 [details] [diff] [review]
Port |bug 640649 - Removed unused cmd_file| to SeaMonkey (v2)
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/c4fd9ad67939

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> >-        return GetNumSelectedMessages() > 0;
> 
> I agree this would make SM more like TB.
> But you should search history and explain whether/why we want that change too.

I filed (TB) bug 650703, fwiw.