647346 - flaggings field should have db_index=True

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Fred Wenzel [:wenzel]]

At least one view has this:

        all_marks = Mark.objects.exclude(flaggings__gte=1)

The flaggings field should have a DB index.

In fact, a typical run of the app should now produce any queries that are inefficient.

Comment 1

[claudia // barbarian]

from our team: 

[master b7fc417] adding indexes for integer / datetime columns
2 files changed, 65 insertions(+), 3 deletions(-)

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> from our team: 
> 
> [master b7fc417] adding indexes for integer / datetime columns
> 2 files changed, 65 insertions(+), 3 deletions(-)

Please link to your commits; thanks.

Comment 3

[Adam Miller]

Here you go: https://github.com/mozilla/markup/commit/b7fc4173479fd8cadb5ee9c95b289a142962505a

Comment 4

[Matt Brandt [:mbrandt]]

Fred (or anyone else), does the commit (comment 3) resolve this for the group?

Comment 5

[Fred Wenzel [:wenzel]]

Yup.