647351 - mochitest-other file "bug497875-iframe.xul" references external (& broken) URL ftp://mozilla.org/

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Daniel Holbert [:dholbert]]

In digging through a debug mochitest-oth failure today, I noticed a series of error messages like the following:
{
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIDOMXULDocument.loadOverlay]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://mochitests/content/chrome/content/xul/document/test/bug497875-iframe.xul :: onerror :: line 1"  data: no]
Failed to load ftp://mozilla.org/
WARNING: NS_ENSURE_SUCCESS(rv, 0) failed with result 0x8000FFFF: file /builds/slave/cen-lnx64-dbg/build/content/base/src/nsContentUtils.cpp, line 2905
WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file /builds/slave/cen-lnx64-dbg/build/content/xbl/src/nsXBLProtoImplMethod.cpp, line 327
}

In particular "Failed to load ftp://mozilla.org/" jumped out at me, since this had happened at the same time as a network blip -- but it turns out we print the above failure 4 times in every m-oth debug test log, regardless of network connectivity.

I think we'd asserted at some point that tests weren't allowed to try to access external URLs.  Mats, do you know if ftp://mozilla.org/ specifically relevant in this case, or could it be replaced with some non-network resource? (something like ftp://mochi.test:8888/ ? I'm not sure if that'd work - I just took it from https://developer.mozilla.org/en/Mochitest and applied s/http/ftp/.)

For reference, here's a sample green tinderbox log from today that has these error messages in it (but any debug mochitest-other log should do):
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox&errorparser=unittest&logfile=1301691357.1301694479.14218.gz&buildtime=1301691357&buildname=Rev3%20Fedora%2012x64%20mozilla-central%20debug%20test%20mochitest-other&fulltext=1

Comment 1

[Daniel Holbert [:dholbert]]

(oops, forgot to cc mats when filing -- mats, see comment 0.)

Comment 2

[Mats Palmgren (inactive)]

Yes, I've verified that ftp://mochi.test:8888/ crash without the fix in
bug 497875 crash (on the 1.9.2 branch).  The test pass with the fix.

Comment 3

[Mats Palmgren (inactive)]

Hmm, it doesn't fix the NS_ERROR_FILE_NOT_FOUND problem though...

Comment 4

[Mats Palmgren (inactive)]

Attachment: fix

This fixes the uncaught NS_ERROR_FILE_NOT_FOUND exception.

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 523728 [details] [diff] [review]
fix

Looks ok to me!

Comment 6

[u597032]

Is this bug still relevant or can it be closed by now?

Comment 7

[Daniel Holbert [:dholbert]]

Not relevant anymore. This test was moved in-tree and then was later deleted in https://hg.mozilla.org/mozilla-central/rev/ee4c52cd9d53 for bug 1448162.

So, effectively fixed-via-deletion by bug 1448162.