[L10n] Hardcoded English strings

VERIFIED FIXED

Status

Websites
markup.mozilla.org
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: wenzel, Assigned: Adam Miller)

Tracking

Details

(Reporter)

Description

7 years ago
There's not many of them fortunately, but I found this one for example:

    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/linear.html#L17

    <h3 id="mark-number">{{ _('Mark') }} <span id="mark-id">0</span> of 
    <span id="total-mark-count">0</span> for an open Web.</h3>

I'm suspecting that this is either some testing code and that the '0' 
should in fact be a variable (and that we will need plural support for 
l10n), or that this is something dynamically changed by JavaScript, in 
which case this is likely to be a problem for l10n.

More examples of hardcoded strings:

    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/makemark.html#L37
    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/moderate.html#L8
(Reporter)

Updated

7 years ago
Severity: minor → normal
Assignee: nobody → adam
(Assignee)

Comment 1

7 years ago
Fixed in: https://github.com/mozilla/markup/commit/91921f4bd0f528029c4ca12c923a498035bb4f9d#ffdemo/templates_orig/sammy/makemark.html
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
This looks much better now, thanks Adam.  Marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.