647380 - [L10n] Hardcoded English strings

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Fred Wenzel [:wenzel]]

There's not many of them fortunately, but I found this one for example:

    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/linear.html#L17

    <h3 id="mark-number">{{ _('Mark') }} <span id="mark-id">0</span> of 
    <span id="total-mark-count">0</span> for an open Web.</h3>

I'm suspecting that this is either some testing code and that the '0' 
should in fact be a variable (and that we will need plural support for 
l10n), or that this is something dynamically changed by JavaScript, in 
which case this is likely to be a problem for l10n.

More examples of hardcoded strings:

    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/makemark.html#L37
    https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/sammy/moderate.html#L8

Comment 1

[Adam Miller]

Fixed in: https://github.com/mozilla/markup/commit/91921f4bd0f528029c4ca12c923a498035bb4f9d#ffdemo/templates_orig/sammy/makemark.html

Comment 2

[Staś Małolepszy :stas]

This looks much better now, thanks Adam.  Marking verified.