Closed
Bug 64752
Opened 24 years ago
Closed 24 years ago
Crash with DOMParser.parseFromString() with empty string
Categories
(Core :: XML, defect, P2)
Tracking
()
VERIFIED
WORKSFORME
mozilla0.9
People
(Reporter: guninski, Assigned: hjtoi-bugzilla)
Details
(Keywords: crash)
Attachments
(2 files)
|
170 bytes,
text/html
|
Details | |
|
2.39 KB,
patch
|
Details | Diff | Splinter Review |
The following crashes Mozilla:
----------------------------------------------------------
<HTML>
Written by <A HREF="http://www.guninski.com">Georgi Guninski</A>
<BR>
<SCRIPT>
a=new DOMParser();
b=a.parseFromString("","text/xml");
</SCRIPT>
</HTML>
----------------------------------------------------------
|
||
Comment 1•24 years ago
|
||
->DOM
Assignee: mstoltz → jst
Status: UNCONFIRMED → NEW
Component: Security: General → DOM Level 0
Ever confirmed: true
QA Contact: ckritzer → desale
|
||
Comment 2•24 years ago
|
||
I believe Heikki is working in this area now so I'm reassigning to him.
Assignee: jst → heikki
|
|
||
Updated•24 years ago
|
|
Assignee | |
Comment 3•24 years ago
|
||
Right. DOMParser is part of the XMLExtras component. This should be trivial to fix.
Status: NEW → ASSIGNED
Component: DOM Level 0 → XML
Summary: Crash with DOMParser() → Crash with DOMParser.parseFromString() with empty string
Target Milestone: --- → mozilla0.9
|
|
Assignee | |
Comment 4•24 years ago
|
||
|
|
Assignee | |
Comment 5•24 years ago
|
||
Weird.. but this one is not crashing for me either with today's build on NT
(plus some of my changes). I can see that there is something wrong in erroneous
cases (we are not setting the return value to nul), but giving an empty string
to parse does not seem cause a crash on me. I'll attach a fix for those, but
could somebody please test this on a recent build to see if this still occurs?
Priority: -- → P2
|
|
Assignee | |
Comment 6•24 years ago
|
||
|
|
||
Comment 7•24 years ago
|
||
Oh, I think I know what caused this, Rick Gessners checkins to the parser a few
days ago had an boog in it, he made some changes to the XML error reporter that
caused a crash if it was ever called (wrong format string to printf, %s in stead
of %d), I checked in a fix yesterday morning so it doesn't crash there any more.
I happen to have a build with that bad code still and I do crash when loading
that testcase.
I believe this is FIXED, feel free to leave this open if you wanna roll in the
changes you have on this bug...
|
|
Assignee | |
Comment 8•24 years ago
|
||
jst, can you r=?
|
|
||
Comment 9•24 years ago
|
||
r=jst
|
|
||
Comment 10•24 years ago
|
||
sr=vidur for the cleanup.
|
|
Assignee | |
Comment 11•24 years ago
|
||
I checked in the fix, but as Johnny said this was probably the bug introduced by
rickg and fixed by Johnny. Marking wfm.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•