Closed Bug 647550 Opened 9 years ago Closed 9 years ago

Signed-unsigned comparison in nsIconChannel::InitWithGnome

Categories

(Core :: ImageLib, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

(Whiteboard: [build_warning])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #523864 - Flags: review?(bobbyholley+bmo)
Flags: in-testsuite-
Comment on attachment 523864 [details] [diff] [review]
Patch v1


>+  if (gdk_pixbuf_get_width(buf)  != int(iconSize) &&
>+      gdk_pixbuf_get_height(buf) != int(iconSize)) {

Instead, please do:

>+  if ((PRUint32)gdk_pixbuf_get_width(buf)  != iconSize &&
>+      (PRUint32)gdk_pixbuf_get_height(buf) != iconSize) {

r=bholley with that.
Attachment #523864 - Flags: review?(bobbyholley+bmo) → review+
Sure thing.
Attachment #523864 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [build_warning][needs review] → [build_warning]
http://hg.mozilla.org/mozilla-central/rev/0243906e7371
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.