Closed
Bug 647550
Opened 13 years ago
Closed 13 years ago
Signed-unsigned comparison in nsIconChannel::InitWithGnome
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 1 obsolete file)
|
986 bytes,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #523864 -
Flags: review?(bobbyholley+bmo)
Flags: in-testsuite-
|
||
Comment 1•13 years ago
|
||
Comment on attachment 523864 [details] [diff] [review] Patch v1 >+ if (gdk_pixbuf_get_width(buf) != int(iconSize) && >+ gdk_pixbuf_get_height(buf) != int(iconSize)) { Instead, please do: >+ if ((PRUint32)gdk_pixbuf_get_width(buf) != iconSize && >+ (PRUint32)gdk_pixbuf_get_height(buf) != iconSize) { r=bholley with that.
Attachment #523864 -
Flags: review?(bobbyholley+bmo) → review+
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [build_warning][needs review] → [build_warning]
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0243906e7371
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•