647600 - crash [@ AsyncCallbackAutoLock::AsyncCallbackAutoLock ]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

This crash showed up in the last day or two, so far only on Mac OS X:

0 	XUL 	AsyncCallbackAutoLock::AsyncCallbackAutoLock 	Mutex.h:106
1 	XUL 	nsNPAPIPluginInstance::Stop 	modules/plugin/base/src/nsNPAPIPluginInstance.cpp:193
2 	XUL 	nsPluginHost::DestroyRunningInstances 	modules/plugin/base/src/nsPluginHost.cpp:4224
3 	XUL 	nsPluginHost::Destroy 	modules/plugin/base/src/nsPluginHost.cpp:870
4 	XUL 	nsPluginHost::Observe 	modules/plugin/base/src/nsPluginHost.cpp:3526
5 	XUL 	nsObserverList::NotifyObservers 	xpcom/ds/nsObserverList.cpp:130
6 	XUL 	nsObserverService::NotifyObservers 	xpcom/ds/nsObserverService.cpp:182
7 	XUL 	mozilla::ShutdownXPCOM 	xpcom/build/nsXPComInit.cpp:627
8 	XUL 	ScopedXPCOMStartup::~ScopedXPCOMStartup 	toolkit/xre/nsAppRunner.cpp:1115
9 	XUL 	XRE_main 	toolkit/xre/nsAppRunner.cpp:1118
10 	firefox-bin 	main 	browser/app/nsBrowserApp.cpp:158
11 	firefox-bin 	firefox-bin@0x953

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Restore null checks

These null checks scare me, but bug 645263 regressed this so here we are.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4e1710fd488a

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks!