Closed Bug 647622 Opened 15 years ago Closed 15 years ago

Tinderbox Valgrind builds broken by elfhack

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: regression)

If you go way back, to the last Valgrind run before elfhack was disabled in February, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1298838386.1298839353.10992.gz complains (easy text to find the start of the actual run is "/usr/bin/valgrind") about how it "Can't make sense of .plt section mapping" in libbrowsercomps.so and libnssckbi.so. The next Valgrind run after it was disabled, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1298926078.1298927215.26927.gz, has no complaints. The last run before the build-system merge, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1300754822.1300755460.24565.gz, remains happy. The run on the build-system merge (when elfhack was re-enabled, along with lots of other stuff, so I don't actually know what's to blame), http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1300846734.1300851818.7976.gz, now can't make sense of libxul.so, libnspr4.so, libmozsqlite3.so, libssl3.so, libnss3.so, libnssutil3.so, libbrowsercomps.so, libsoftokn3.so, libfreebl3.so, or libnssckbi.so, so it pretty much only sees into system libraries, and draws a blank on where anything might have happened within Firefox. The 32-bit runs, like http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1300839729.1300846027.19289.gz, only complain of not understanding libxul.so, but that's a sort of handy thing to understand.
This could be a problem with valgrind making some wrong assumptions about elf headers. Or elfhack subtly breaking some things. I'll check which it is.
From the valgrind source, it looks like it assumes there's only one PT_LOAD for executable stuff... so that would be a valgrind bug.
cc'ed them on every Valgrind bug I've filed when I didn't need to, so of course I didn't on the one where I should have.
(In reply to comment #2) > From the valgrind source, it looks like it assumes there's only one PT_LOAD for Yeah .. I suspect there's a bug on this in the Valgrind bug tracker. I'll dig it up.
Depends on: 647673
Filed bug 647673 on doing --disable-elf-hack in the Valgrind tests for now, so this bug is probably invalid.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
Summary: Tinderbox Valgrind builds broken by build-system merge → Tinderbox Valgrind builds broken by elfhack
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.