Closed Bug 647655 Opened 13 years ago Closed 11 years ago

Exiting from Private Browsing mode don't restore previous tabs if Firefox is launched in Private mode from jumplist

Categories

(Firefox :: Private Browsing, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: aymonee, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

When I start firefox directly in private browsing from the jump list, and then I press ctrl shift P to go back to normal browsing, I lose all the pinned tabs I previously saved.

Reproducible: Always

Steps to Reproduce:
1.Open firefox in private mode from the jump list
2.Go back to normal mode

Actual Results:  
Pinned tabs are lost.

Expected Results:  
After switching back from private to normal browsing I do expect the browser to load back my previously pinned tabs.
Works for me on:
 Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0

This is not a bug. Please refer to this article regarding private browsing
http://support.mozilla.com/en-US/kb/Private%20Browsing

The status of this bug should be changed to resolved.
I didn't explain enough or you didn't understand me.

Let's say I pin a tab while in normal mode, now if I go in private mode when i switch back in normal mode I get again the pinned tab. I'M NOT PINNING TABS IN PRIVATE MODE.
This means that if I pin a tab while in normal mode, it hides while in private mode, but it shows again when in normal mode.

Now, what if I pinned a tab and I close the browser.

If I open firefox in normal mode the pinned tabs are there. If I open firefox the pinned tabs are Completly Lost. 

I can close firefox, I can switch back to normal mode or anything, but they are just lost.

This can't be a normal behaviour.
aymonee@gmail.com, what if you have both pinned tabs and non-pinned tabs... Do the non-pinned tabs survive your exercises but the pinned tabs disappear? Or does this alleged bug only occur if you have pinned tabs only?
I can't have pinned tabs cause I'm using the jump list in the win7 taskbar to open firefox in private mode.
Reproducible on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0

*Note. Bug can be marked as NEW if not a dupe
(In reply to comment #4)
> I can't have pinned tabs cause I'm using the jump list in the win7 taskbar to
> open firefox in private mode.

In that comment I meant: 'I can't have OPENED tabs'
Status: UNCONFIRMED → NEW
Ever confirmed: true
same problem here, i lost 20 opened tabs because of this bug.

the steps are:
0-set firefox to save the opened tabs when you close it (so it reopen them when starting in normal mode)
1-have some tabs opened, close firefox.
2-right click and open in Private Mode from Windows7 taskbar.
3-EXIT from Private Mode with Ctrl-Shift+P and, surprise, all your tabs/groups are gone. They are not restored, they are not in any other window. They are gone forever.

i will never use the taskbar option anymore for private mode.
additional steps for this behaviour:

0-set firefox to save the opened tabs when you close it (so it reopen them when
starting in normal mode)
1-have some tabs opened, close firefox.
2-right click and open in Private Mode from Windows7 taskbar.
3-close firefox.
4-reopen firefox, all my tabs and groups are in places, nothing lost.
Moving to a more specific component.
Component: General → Private Browsing
QA Contact: general → private.browsing
Summary: Pinned tabs not restored after starting firefox 4 in private browsing → Exiting from Private Browsing mode don't reopen previous tabs if Firefox is launched in Private mode from taskbar
Summary: Exiting from Private Browsing mode don't reopen previous tabs if Firefox is launched in Private mode from taskbar → Exiting from Private Browsing mode don't restore previous tabs if Firefox is launched in Private mode from jumplist
I confirm this bug in FF 5.0. Pinned tabs are usually restored correctly, but not when FF is started directly in private mode. Note that if you exit FF without leaving private mode, pinned tabs are not lost; they're lost only if you start FF directly in private mode (from Win7 jump list) AND you leave private mode explicitly.
(In reply to comment #10)
> they're lost only if you start FF directly in private mode (from Win7 jump 
> list) AND you leave private mode explicitly.

That almost sounds like that's how it SHOULD behave. In other words, everything from ANY Private Browsing session should NEVER be accessible from a NORMAL session. Am I incorrect in that statement?
> That almost sounds like that's how it SHOULD behave. In other words,
> everything from ANY Private Browsing session should NEVER be accessible from
> a NORMAL session. Am I incorrect in that statement?

I did my best to explain my problem as clearly as possible, but apparently it was still not clear ;)
I didn't pin the tabs in a private browsing session, I pinned them before in a normal session, then closed FF. In private mode, they don't show up, which is correct, but they are normally restored when I leave private mode. In the case I describe, they're not restored and they are completely lost.
and are lost not only pinned tabs, but ALL tabs, as described in bug title!
Ok, let me make another attempt to understand...

Expected:
Normal mode -> Session with Tabs and AppTabs
Restart Firefox in Private Browsing -> Session without those Tabs and AppTabs
Exit Private Browsing -> Restore those Tabs and AppTabs

Actual:
Normal mode -> Session with Tabs and AppTabs
Restart Firefox in Private Browsing -> Session without those Tabs and AppTabs
Exit Private Browsing -> Session without those Tabs and AppTabs

If I am correct in this assumption, are the tabs restorable via History > Restore Previous Session?
Yes, your description of the problem is correct. The tabs can't be restored via History > Restore Previous Session (this option is disabled in the menu)
have you ever read this?

"the steps are:
0-set firefox to save the opened tabs when you close it (so it reopen them when starting in normal mode)
1-have some tabs opened (in normal mode), close firefox.
2-right click and "Enter Private Browsing" from Windows7 taskbar icon of firefox.
3-EXIT from Private Mode with Ctrl-Shift+P and, all your tabs/groups are gone. They are not restored, they are not in any other window."
Actually step 0 is not mandatory, you can also observe the problem for pinned tabs if you don't set FF to save open tabs (since pinned tabs are always saved)
[ Just lost session this way again. ]
BTW why is it not the way it used to be long time ago? When starting firefox with "-private" switch the option in menu to exit from Private Mode and Ctrl-Shift+P shortcut were disabled.
It should be just one "if (started with -private) { disable this function }", I'm new on bugzilla, but I can try to search for place to put it in firefox source code.
I looked through the code a bit and it seems to be rather tricky.

The jumplist flag is "-private-toggle", not "-private".

I think the problem is in this function:
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/src/nsPrivateBrowsingService.js#133
I think in that case Firefox assumes that the browser state needs to be saved before switching to PB mode although the browser only just started.

I guess much of this code will be removed with per-window PB, right?
Is it still worth it to work on this bug? Is there a plan for when per-window PB will be ready?
this bug is resolved for me since per-windows private tab in Fx20.
WFM as well with the new per-window private mode. Could no longer reproduce after following the steps in comment 0.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.