Closed Bug 647667 Opened 15 years ago Closed 10 years ago

Test Pilot makes toolbar icons big, navigation buttons stretched in Firefox 4+

Categories

(Mozilla Labs Graveyard :: Test Pilot, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jara.karel, Unassigned)

Details

(Whiteboard: ui)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0 Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0 Test Pilot 1.1 makes icons in toolbar buttons big (24px) althought they should be always small (16px) on Windows, as far as I know. This causes back and forward buttons to stretch. My case: When I start Firefox, goo.gl lite extension button has big icon (24px). If I set small icons, it goes to small button with small icon. If I set back to big icons, it goes to slightly bigger button with small icon. The last is the desirable design with big icons set, in my opinion. This has also been discussed in bug 644973. I’m taking the screenshot from there where there is some other extension in use but it’s perfectly what I’m talking about. Reproducible: Always Steps to Reproduce: 1. Install Test Pilot and have another extension installed with toolbar button placed. 2. Start Firefox. Actual Results: Big icon in toolbar button is displayed. Expected Results: Small icon in somewhat bigger button then with small-icon setting should be displayed.
Hi Karel, Thanks for reporting the bug. When this problem happens, do you have the Feedback button in your toolbar or not? I ask because there are two different versions of the Test Pilot UI (one with Feedback button, one without) and I'm trying to figure out which UI version the problem is related to.
Whiteboard: needs-reproducing, ui
This is with Test Pilot which shows itself as Test Pilot in the list of add-ons. The other one I think showed itself as Feedback. I don’t have the Feedback button in the toolbars now nor can it be added. So I think I installed it from the Test Pilot page into the stable Firefox 4 version. Now I have Firefox 5 Beta and still no Feedback button.
And of course, still big icon after restart as described in the bug report.
Hey! How is it possible that this bug is still unconfirmed?! This has been issue for a long time and it really bothers me to switch small icons on and off after every start of Firefox. :-/
This is an issue I complained about over a year ago. the issue is that Test Pilot adds menu items to a toolbar with css rules that make it's height bigger than the normal height of that toolbar if you have customized Firefox to be using small icons.
Status: UNCONFIRMED → NEW
Ever confirmed: true
BTW this is one of the reasons that all of the feedback you get from testpilot is useless. May people just uninstall it as being broken because it screws up their menubar display.
Disabling test pilot till this gets fixed. Really annoying.
This bug has been reported multiple times here: https://addons.mozilla.org/z/en-US/firefox/compatibility/reporter/testpilot@labs.mozilla.com STR: Install Test Pilot and WOT. Observed: The WOT icon is bigger than that button that should contain it. Toggling the "Use small icons" option in the Customize Toolbars dialog fixes the problem temporarily. Restarting Firefox makes the problem return. Disabling Test Pilot fixes the problem. Tested in Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a2) Gecko/20120112 Firefox/11.0a2
Severity: normal → major
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: needs-reproducing, ui → ui
Summary: Test Pilot makes toolbar icons big, navigation buttons stretched in FF4 on Windows → Test Pilot makes toolbar icons big, navigation buttons stretched in Firefox 4+
The cause of this is the dynamic loading of overlays using document.loadOverlay. The reference code is (both forks in this function show same issue): http://hg.mozilla.org/labs/testpilot/file/da10ecb3bce1/extension/modules/interface.js#l157 But I have not tracked down *why*. For example, stripping all the XUL out of the overlay does not resolve the issue, neither does removing CSS includes. So this seems to show that it is not actually any content stretching the UI.
Product: Mozilla Labs → Mozilla Labs Graveyard
decommissioned
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: