647898 - Links from SeaMonkey Nightly Builds page are broken

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[rsx11m]

As reported in the MozillaZine forums a couple of days ago, the nightly-build links from the web site are broken and cause a "not found" error.

http://www.seamonkey-project.org/dev/nightly

The reason appears to be that they try to find 2.1b3pre in comm-central-trunk.

Comment 1

[rsx11m]

Either make it seamonkey/nightly/latest-comm-2.0/seamonkey-2.1b3pre.* or seamonkey/nightly/latest-comm-central-trunk/seamonkey-2.2a1pre.* instead,
where the comm-central/mozilla-2.0 builds may be the preferred ones until SeaMonkey 2.1 is closing in on release and comm-central/mozilla-central
gets the attention again.

Comment 2

[Robert Kaiser]

The problem there is that's I'm not sure that linking to 2.2a1pre builds is what we want there, but linking to comm-2.0 would need a larger change in the website template to do it correctly.

Linking to 2.2a1pre would just be a change of the variable in the config.tmpl file (I think that's what it's called).

Comment 3

[rsx11m]

(In reply to comment #2)
> The problem there is that's I'm not sure that linking to 2.2a1pre builds is
> what we want there,

Agreed, the last comm-central/mozilla-central nightly was March 31, so that's spotty (and likely buggy) at best.

> but linking to comm-2.0 would need a larger change in the
> website template to do it correctly.

If you look at it from the positive side, this may be a good opportunity to make the template more general to be covered in future similar situations.  ;-)

Comment 4

[rsx11m]

Looking at seamonkeyproject-org/src/dev/nightly.en.html, the path constructs
as [% develdownloadbase %]/seamonkey-[% develversion %].en-US.*, thus another level for the branch would be needed with a similar variable in config.tmpl,
[% develdownloadbase %]-[% develbranch %]/seamonkey-[% develversion %].en-US.*

  develdownloadbase = http://.../latest-comm
  develbranch = 2.0
  develversion = 2.1b3pre

This might be the most flexible solution.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 9]

I don't see why it cannot be this simple. What did I miss?

Comment 6

[rsx11m]

>-[% develdownloadbase = 'http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-comm-central-trunk' %]
>+[% develdownloadbase = 'http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-comm-2.0' %]

Yes, I was thinking about this "too simple solution" after posting comment #4, but wasn't sure if it's used anywhere else too - apparently it isn't.  :-)

Comment 7

[Robert Kaiser]

Comment on attachment 525412 [details] [diff] [review]
patch [Checkin: comment 9]

Oh, cool, I _did_ build in a variable for this. Cool, thanks for looking it up. :)

Comment 8

[Robert Kaiser]

(oh, and thanks for spotting the mac thing as well)

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 525412 [details] [diff] [review]
patch [Checkin: comment 9]

Checking in lib/config.tmpl;
/www/seamonkeyproject-org/lib/config.tmpl,v  <--  config.tmpl
new revision: 1.54; previous revision: 1.53
done
Checking in src/dev/nightly.en.html;
/www/seamonkeyproject-org/src/dev/nightly.en.html,v  <--  nightly.en.html
new revision: 1.5; previous revision: 1.4
done