64791 - [xlib port]menus dismiss when they shouldn't

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

In the xlib port, the menus on the main menubar at the top of the navigator
window dismiss if you:
 * click on the menu title
 * wait for the menu to open
 * move the mouse off the menu title (i.e., down to click on an item)

I've traced the problem this far back:
 
 * nsMenuFrame::HandleEvent does the wrong thing when handling the mouse exit
event because the nsMenuBarFrame's mIsActive is false when it should be true
 * nsMenuBarFrame::mIsActive is false because there was an extra call to
nsMenuBarFrame::ToggleMenuActiveState() after the call to
nsMenuBarFrame::SetActive(PR_TRUE).  I looked at the stack for this call once --
I think it might have had something to do with a blur event on the URL bar, but
I need to look more closely.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: stack trace of bad call to nsMenuBarFrame::ToggleMenuActiveState

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

My guess is that the nsAppShell in the xlib port is sending extra focus/blur
events that other ports aren't sending.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The code corresponding to the Xlib blur event (NS_DEACTIVATE) code in
widget/src/xlib/nsAppShell.cpp in the GTK port is in widget/src/gtk/nsWindow.cpp

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch that seems to work

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Ken Faulkner - you seem to have worked on focus stuff judging by the comments in
the code.  Does this seem reasonable to you?

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Apparently the folks at igelaus.com.au have lots of patches they haven't checked
in yet, so I'll move this to Future on the assumption that they've probably
already fixed it...

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Apparently they don't have patches for this one...

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2001-03-09 19:45 PST.