Closed
Bug 647927
Opened 13 years ago
Closed 13 years ago
Add SpiderMonkey builds that fail on warnings
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: catlee)
References
Details
Attachments
(2 files, 1 obsolete file)
526 bytes,
patch
|
catlee
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
2.00 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
Assuming bug 646702 lands as-is, we want to add both opt and debug SpiderMonkey builds that pass --enable-sm-fail-on-warnings to configure, on Linux and Mac.
Reporter | ||
Comment 1•13 years ago
|
||
If I understood the patch that created the other SM builds, and the one that switched them to debug, then this ought to give us builds I can spot in tbpl as "warnaserr" and as "debug" for the debug ones.
Attachment #524129 -
Flags: review?(catlee)
Reporter | ||
Comment 2•13 years ago
|
||
Attachment #524130 -
Flags: review?(catlee)
Assignee | ||
Updated•13 years ago
|
Attachment #524130 -
Flags: review?(catlee) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #524129 -
Flags: review?(catlee) → review+
Reporter | ||
Updated•13 years ago
|
Attachment #524129 -
Flags: checked-in?
Reporter | ||
Updated•13 years ago
|
Attachment #524130 -
Flags: checked-in?
Assignee | ||
Updated•13 years ago
|
Assignee: philringnalda → catlee
Priority: -- → P2
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 524129 [details] [diff] [review] buildbot-configs, v.1 http://hg.mozilla.org/build/buildbot-configs/rev/0e743bbb306c
Attachment #524129 -
Flags: checked-in? → checked-in+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 524130 [details] [diff] [review] tools/scripts, v.1 http://hg.mozilla.org/build/tools/rev/c31c8e0757ce
Attachment #524130 -
Flags: checked-in? → checked-in+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 524129 [details] [diff] [review] buildbot-configs, v.1 Something broke thusly: Traceback (most recent call last): File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.6/site-packages/buildbot-0.8.2_hg_c3083a37cd1a_default-py2.6.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig ConfigLoader(configFileName=configFileName) File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.6/site-packages/buildbot-0.8.2_hg_c3083a37cd1a_default-py2.6.egg/buildbot/scripts/checkconfig.py", line 31, in __init__ self.loadConfig(configFile, check_synchronously_only=True) File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.6/site-packages/buildbot-0.8.2_hg_c3083a37cd1a_default-py2.6.egg/buildbot/master.py", line 624, in loadConfig exec f in localDict File "/builds/buildbot/preproduction/slave/test-masters/buildbot-configs/master_dir/master.cfg", line 50, in <module> projectObjects = generateProjectObjects(project, PROJECTS[project], SLAVES) File "/builds/buildbot/preproduction/slave/test-masters/buildbotcustom/misc.py", line 3265, in generateProjectObjects spiderMonkeyObjects = generateSpiderMonkeyObjects(config, SLAVES) File "/builds/buildbot/preproduction/slave/test-masters/buildbotcustom/misc.py", line 3134, in generateSpiderMonkeyObjects 'env': config['env'][platform], KeyError: 'linux64'
Attachment #524129 -
Flags: checked-in+ → checked-in-
Assignee | ||
Comment 6•13 years ago
|
||
Add missing environment settings
Attachment #524129 -
Attachment is obsolete: true
Attachment #525706 -
Flags: review?(bhearsum)
Updated•13 years ago
|
Attachment #525706 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 525706 [details] [diff] [review] buildbot-configs, v.2 http://hg.mozilla.org/build/buildbot-configs/rev/95cc081632fe
Attachment #525706 -
Flags: checked-in+
Reporter | ||
Comment 8•13 years ago
|
||
Running, and even more remarkable, green!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
(In reply to comment #8) > Running, and even more remarkable, green! This sounds like a bug, but I read through one log, and it does appear to be working right and warning free. I don't see this on tbpl.mozilla.org? Do I just need to wait a bit?
Reporter | ||
Comment 10•13 years ago
|
||
Yup, or use http://dev.philringnalda.com/tbpl/?tree=TraceMonkey in the meantime - I really like to wait until after they are running to push the tbpl change, since I usually screw up something about build names if I don't.
Comment 11•13 years ago
|
||
(In reply to comment #9) > (In reply to comment #8) > > Running, and even more remarkable, green! > > This sounds like a bug I'm not surprised, it hasn't been that long since bug 609532 was backed out.
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•