648138 - Preview broken on localized discussion forums

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P3)

Description

[James Socol [:jsocol, :james]]

We don't officially support the discussion forums in other languages, the UI isn't localized[1], for example. Though at this point I think there's very little burden left to localizers (most, if not all, of the strings are already localized from other apps). We could revisit that and stop ignoring the forums app.

Before or when we do that we should fix the way previewing posts/replies is broken in non-English.

Comment 1

[Scoobidiver (away)]

I tested it for several locales and the previewing is only broken for fr and pt-BR.
I have used the French contributor forum for several months and it happened for the first time on April, 1st, may be after the fixing of bug 647240.

Comment 2

[James Socol [:jsocol, :james]]

https://github.com/jsocol/kitsune/commit/0d4c2ff36fb

Comment 3

[Rebecca Billings [:rbillings]]

1) https://support.allizom.org/fr/forums/contributors/
2) log in> post new thread
3) add title, content> click Apercu

expected: preview
actual: error
traceback: UndefinedError: 'forums.models.Post object' has no attribute 'author_post_count'
page error: Une erreur s'est produite.

Oh non ! Il semblerait qu'une erreur inattendue se soit produite. Les administrateurs ont déjà été prévenus. Veuillez réessayer immédiatement, ou dans quelques minutes.

Comment 4

[James Socol [:jsocol, :james]]

Forgot to fix previews on new threads.

master: https://github.com/jsocol/kitsune/commit/e35bd18ea0
next: https://github.com/jsocol/kitsune/commit/5c6685f9

Comment 5

[Rebecca Billings [:rbillings]]

Verified able to successfully preview new threads & responses in non-US contributors forums