install-module.pl should check if a compiler is available, and fail with a clear error if one is not

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Installation & Upgrading
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: glob, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 4.2
x86
Linux
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
install-module.pl should check if a compiler is available, and fail with a clear error if one is not.

while cpan itself will fail if a compiler is missing, the error message is not clear, and is hidden in a torrent of text.
(Assignee)

Comment 1

7 years ago
Yes, however, it should only do this when you attempt to install something where the module of its dependencies need a compiler. It's very common to just install CGI.pm with install-module, and that does not need a compiler and shouldn't require one.
(Assignee)

Comment 2

7 years ago
Created attachment 526540 [details] [diff] [review]
v1

Okay, I changed my mind to improve the simplicity of implementation. install-module.pl now requires a compiler no matter what you try to do; it basically won't do anything at all without a compiler installed, now.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #526540 - Flags: review?(glob)
(Assignee)

Comment 3

7 years ago
I only want to do this on trunk; I have no idea how requiring a compiler will affect the support burden. If it's a positive effect, we can backport it to 4.0 for 4.0.2.
Target Milestone: Bugzilla 4.0 → Bugzilla 4.2

Comment 4

7 years ago
Comment on attachment 526540 [details] [diff] [review]
v1

>=== removed file 'lib/README'

Why do you remove this file from the repo?
(Assignee)

Comment 5

7 years ago
Created attachment 526620 [details] [diff] [review]
v2

Was a simple mistake. (It happens if you do "rm -rf lib/*".)
Attachment #526540 - Attachment is obsolete: true
Attachment #526540 - Flags: review?(glob)
Attachment #526620 - Flags: review?(glob)
Attachment #526620 - Flags: review?(LpSolit)
(Reporter)

Comment 6

7 years ago
Comment on attachment 526620 [details] [diff] [review]
v2

looks good, works as advertised.  r=glob
Attachment #526620 - Flags: review?(glob) → review+
(Assignee)

Comment 7

7 years ago
Great, thanks! :-)
Flags: approval+
(Assignee)

Updated

7 years ago
Attachment #526620 - Flags: review?(LpSolit)
(Assignee)

Comment 8

7 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Install/CPAN.pm
modified Bugzilla/Install/Util.pm
modified template/en/default/setup/strings.txt.pl
Committed revision 7784.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.