648249 - Build error with gcc4.5

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Tommy Reilly]

Hi,

I'm looking at a compile error on GCC4.5. It complains about setting NULL to a non pointer type.

On linux vmpi_thread_t is defined as pthread_t. That's a long int, not a pointer, so the error.

/home/ambry/flash/split/third_party/avmplus/MMgc/GC.cpp: In member function ‘void MMgc::GC::ThreadLeave(bool, MMgc::GC*)’:
/home/ambry/flash/split/third_party/avmplus/MMgc/GC.cpp:3495:26: error: converting to non-pointer type ‘vmpi_thread_t’ from NULL
make[2]: *** [CMakeFiles/mmgc.dir/home/ambry/flash/split/third_party/avmplus/MMgc/GC.cpp.o] Error 1
make[1]: *** [CMakeFiles/mmgc.dir/all] Error 2

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

I'm not an expert in how pthreads are implemented on various host environments, but the spectre of NULL/0 being confused with another valid thread id is a bit scary.  Filed as Bug 656008.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: cleanup handling of markStackSentinel

(unlike pthread_t, this one is super easy to deal with.)

Comment 3

[Tamarin Bot]

changeset: 6296:9c4b988f4c07
user:      Felix S Klock II <[e-mail]>
summary:   Bug 648249: cleanup handling of markStackSentinel (r=treilly).

http://hg.mozilla.org/tamarin-redux/rev/9c4b988f4c07

Comment 4

[James Sudduth]

Assigning this since no one did before.

Comment 5

[Dan Smith]

Is this fixed by the submission in comment 3?

Comment 6

[Dan Smith]

This bug, as described is a dup of 656008, but the submitted fixes a related problem.  Closing this bug which fixes a related build error.