Closed
Bug 648338
Opened 14 years ago
Closed 14 years ago
Remove Firefox 3.5/3.6 compat code
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [prune][qa-])
Attachments
(5 files, 1 obsolete file)
|
16.00 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
|
17.65 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
|
6.03 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
|
17.57 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
|
5.05 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
Die m10r die
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #524485 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #524486 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #524487 -
Flags: review?(rnewman)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [prune]
|
||
Updated•14 years ago
|
Attachment #524484 -
Flags: review?(rnewman) → review+
|
|
||
Updated•14 years ago
|
Attachment #524485 -
Flags: review?(rnewman) → review+
|
|
||
Updated•14 years ago
|
Attachment #524486 -
Flags: review?(rnewman) → review+
|
|
||
Updated•14 years ago
|
Attachment #524487 -
Flags: review?(rnewman) → review+
|
|
||
Comment 5•14 years ago
|
||
All of these look good, and pass CrossWeave.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Also get rid of the Svc.Crypto fallback code
Attachment #524487 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•14 years ago
|
||
Part 1: http://hg.mozilla.org/services/services-central/rev/f73ae964d033
Part 2: http://hg.mozilla.org/services/services-central/rev/20ab4d32a215
Part 3: http://hg.mozilla.org/services/services-central/rev/7249a4758419
Part 4: http://hg.mozilla.org/services/services-central/rev/7a31e6545943
Whiteboard: [prune] → [prune][fixed in services]
|
|
||
Updated•14 years ago
|
Attachment #524510 -
Flags: review+
|
|
||
Comment 9•14 years ago
|
||
A little more cleanup. Tests pass.
Attachment #524533 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 10•14 years ago
|
||
Comment on attachment 524533 [details] [diff] [review]
Part 5: PlacesUtils.jsm.
r+'ed like a g6
Attachment #524533 -
Flags: review?(philipp) → review+
|
|
||
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Comment on attachment 524533 [details] [diff] [review]
> Part 5: PlacesUtils.jsm.
>
> r+'ed like a g6
Pushed:
https://hg.mozilla.org/services/services-central/rev/985bf12f7db3
Whiteboard: [prune] → [prune][fixed in services]
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [prune][fixed in services] → [prune][fixed in services][qa-]
|
|
Assignee | |
Comment 12•14 years ago
|
||
Part 1: http://hg.mozilla.org/mozilla-central/rev/f73ae964d033
Part 2: http://hg.mozilla.org/mozilla-central/rev/20ab4d32a215
Part 3: http://hg.mozilla.org/mozilla-central/rev/7249a4758419
Part 4: http://hg.mozilla.org/mozilla-central/rev/7a31e6545943
Part 5: http://hg.mozilla.org/mozilla-central/rev/985bf12f7db3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [prune][fixed in services][qa-] → [prune][qa-]
|
||
Comment 13•14 years ago
|
||
What effect will this have? Which versions of Fx will be able to sync with each other?
|
|
Assignee | |
Comment 14•14 years ago
|
||
(In reply to comment #13)
> What effect will this have?
This has no user visible effect.
> Which versions of Fx will be able to sync with each other?
You'll be able to sync Firefox 3.5/3.6 with the Sync 1.7 add-on, Firefox 4 and Firefox 5.
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → mozilla5
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•