648341 - Cannot remove localizations

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[spmail]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

In top right, you have the option to choose the current localization you're working with.
In the list, there are "X" buttons, to remove a localization.
After clicking it, it seems to be removed from the list, but after refreshing the page, the localization is back - not removed as intended.

There seems to be no update/save button.

Reproducible: Always

Steps to Reproduce:
1. Click the "X" to remove a localization (No update button)
2. Refresh the page
Actual Results:  
The localization was not removed

Expected Results:  
The localization should be removed

Comment 1

[spmail]

Talking about the URL: https://addons.mozilla.org/da/developers/addon/SOME-ADDON-NAME/edit

Comment 2

[Wil Clouser [:clouserw]]

Can you give us the link to your specific add-on?  This doesn't sound like a bug that affects everyone.

Comment 3

[krupa raj[:krupa]]

STR:

1. Pick an add-on with localizations(https://addons.allizom.org/en-US/developers/addon/blahblah123/edit)
2. Delete one of the locales
3. Reload the page


observed behavior:
After page reload, the deleted locale is still listed.


screencast: http://screencast.com/t/VjrrRaAZal

Comment 4

[Wil Clouser [:clouserw]]

-> potch.  This seems like a big deal.  Potch, if this isn't front end, please let us know early so we can get backend eyes on it.

Comment 5

[Potch [:potch]]

seems to be frontend- looking into how to make this work better.

Comment 6

[Potch [:potch]]

After further discussion, the right thing to do here is warn the user they are about to remove all translations for this addon for the given locale, and then remove them if the user opts to proceed. This will require some backend work to handle said POST.

Comment 7

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/a64b356

Comment 8

[krupa raj[:krupa]]

I was able to remove a locale in edit mode. Marking this as verified.