Closed Bug 648378 Opened 9 years ago Closed 9 years ago

"mobile/app/macbuild/.DS_Store" probably shouldn't exist

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

This file:
http://hg.mozilla.org/mozilla-central/annotate/fb566937c787/mobile/app/macbuild/.DS_Store
probably should not exist.

Its HG history is a single changeset, which says:
"Add macbuild files to allow easy building on OS X (copied over from Firefox with s/firefox/fennec/"
http://hg.mozilla.org/mozilla-central/rev/6c3459a8cd4d

...but given that this is the only instance of such a file in mozilla-central (and that our fennec macbuild stuff is apparently supposed to match our desktop macbuild stuff (?)), I'm guessing this file was an instance of accidentally-introduced-OSX-filesystem-cruft. (and hence wants to die)

gavin, can you confirm?
(while we're at it, mobile/app/macbuild/CVS/* (from that same cset) probably all wants to die, too, right?)
Yeah those can all just go (.DS_Store and CVS/*).
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(In reply to comment #2)
> Yeah those can all just go (.DS_Store and CVS/*).

Done, with r=gavin (based on comment 2):
http://hg.mozilla.org/projects/cedar/rev/39c3c868dbd8
(optimistically/ambitiously assumed r=gavin since he's afk at the moment and this is trivial. :))
Whiteboard: fixed-in-cedar
http://hg.mozilla.org/mozilla-central/rev/39c3c868dbd8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Can somebody verify if this is fixed?
Sure - verified based on MXR search in mozilla-central (no hits), vs. the same search in the now-defunct 'mobile-browser' repo, where the DS_Store file was originally (accidentally) introduced (1 hit):
 http://mxr.mozilla.org/mozilla-central/find?string=.DS_Store
 http://mxr.mozilla.org/mobile-browser/find?string=.DS_Store
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.