Closed Bug 648385 Opened 13 years ago Closed 13 years ago

gfxFont::GetUniqueName() is unused & just forwards to GetName

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: zwol, Assigned: zwol)

Details

Attachments

(1 file)

gfxFont has both a GetName and a GetUniqueName method; the former just looks at the name in the font entry, and the latter is virtual, apparently on the theory that some font backends might need to be more specific.  There are a few font backends that override GetUniqueName ... but all of them just call GetName again.  And there's only one user of GetUniqueName in the entire tree.  I think it should go.
Attached patch patchSplinter Review
Like so.
Assignee: nobody → zackw
Status: NEW → ASSIGNED
Attachment #524516 - Flags: review?(jdaggett)
Attachment #524516 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/525a9d7f3437
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: