Closed
Bug 648601
Opened 15 years ago
Closed 15 years ago
Always send shareType in share API calls
Categories
(Cloud Services :: Share: Web Client, defect)
Cloud Services
Share: Web Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: formerly-j-r-burke, Assigned: formerly-j-r-burke)
References
Details
Attachments
(1 file)
Given the historical "only one share option per service" roots of F1, the web code does not send shareType if there is only one sharing option. However, for better, explicit checking for the direct message vs. public share, the shareType should always be sent, to avoid ambiguity.
Note that this change should go out on a web release before the server back end changes to only allow explicit shareType values, which is part of bug 648372.
This change can be pushed out as soon as it is ready though without enabling direct message support.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #525105 -
Flags: review?(mixedpuppy)
|
||
Updated•15 years ago
|
Attachment #525105 -
Flags: review?(mixedpuppy) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
The changes have been merged into web/dev/1 which is used by the integrated Fx UI. With that merge, the fix is complete:
https://github.com/mozilla/f1/commit/bc0f61c89619c9504a0556c4780c897429888c48
Status: NEW → RESOLVED
Closed: 15 years ago
Component: Share: Web Client → Server: Sync
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Component: Server: Sync → Share: Web Client
You need to log in
before you can comment on or make changes to this bug.
Description
•