Closed Bug 648604 Opened 11 years ago Closed 11 years ago

Enable non-accelerated OpenGL reftests for Linux machines

Categories

(Release Engineering :: General, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mattwoodrow, Assigned: armenzg)

References

Details

(Whiteboard: [unittest])

Attachments

(3 files)

OpenGL reftests on the fedora machines are now green on tryserver, so we need to get testing coverage of this as soon as possible.

We should use the layers.acceleration.force-enabled/disabled config flags so that both configurations are unaffected when we enable acceleration by default.

Given that we are only whitelisting nvidia hardware, with recent official drivers, we can't afford to lose testing coverage for the non-accelerated case.

I would like to enable OpenGL by default as soon as possible into the Firefox 6 development cycle (next week!) to try work out any issues. I believe the extent of our troubles with GPU drivers on linux is well known.
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [unittest]
Priority: P3 → P2
Priority: P2 → P3
Sorry I took long to reply I had releases and fires going on.

Let sum up what I have understood:
* currently hardware acceleration is green for Fedora12/rev3's graphic card
** would you please be able to push it once more to the tryserver and paste the results in here?
* you want to enable hardware acceleration by default + some whitelisting
** do you have the info you need to not whitelist the rev3 machines?
* you want to also run a separate reftest suite w/o hardware acceleration
** like what we did for direct2D/3D in bug 610493

The changes required would be something like this:
* http://hg.mozilla.org/build/buildbotcustom/rev/59f35f922f09
* http://hg.mozilla.org/build/buildbot-configs/rev/531efa39e54d

I think the summary of the bug should be:
"Add non-accelerated reftest for Fedora so we can enable by default the hardware acceleration"

* Is this for Fed12 32-bit as well as Fed12 64-bit?
* What are the parameters needed to disable the HW acceleration even if the build comes with it enabled by default?

This would cause adding more load to the testing pool so we have to be sure that this is going forward.
Matt how does the above sound to you?
(In reply to comment #1)
> Sorry I took long to reply I had releases and fires going on.
> 
> Let sum up what I have understood:
> * currently hardware acceleration is green for Fedora12/rev3's graphic card
> ** would you please be able to push it once more to the tryserver and paste the
> results in here?

Sure, I'll do this soon.

> * you want to enable hardware acceleration by default + some whitelisting
> ** do you have the info you need to not whitelist the rev3 machines?

Not sure what you mean, the current Fedora machines are already on our whitelist.

> * you want to also run a separate reftest suite w/o hardware acceleration
> ** like what we did for direct2D/3D in bug 610493

Correct.


> * Is this for Fed12 32-bit as well as Fed12 64-bit?

Yes.

> * What are the parameters needed to disable the HW acceleration even if the
> build comes with it enabled by default?

I think we should set layers.acceleration.disabled = true on one run and layers.acceleration.force-enabled = true on the other so that both configurations are always run regardless of the default setting.

> 
> This would cause adding more load to the testing pool so we have to be sure
> that this is going forward.
Try results at: http://tbpl.mozilla.org/?tree=Try&rev=9d9fa0413474

Looks like they all have one failed tests, but it's an unexpected pass.
Attachment #529923 - Flags: review? → review?(joe)
Attachment #529923 - Flags: review?(joe) → review+
Landed the reftest fix as http://hg.mozilla.org/mozilla-central/rev/a3cc29e7e3b9

We should be all green and ready to go here now. :)
Just to clarify, I only want one new reftest run per platform, for a total of two.

I just want the two reftest configurations to be independent of the default switch.

Is it possible to get an estimated time frame for this? I'd quite like to trial enabling OpenGL layers by default before we branch for the next aurora.
It is going to be tight as there was also the ipcplugins re-org work holding me back.

I will let you know more by the end of the day.
Matt how does this look?

python reftest/runreftest.py --appname=firefox/firefox-bin --utility-path=bin --extra-profile-file=bin/plugins --symbols-path=symbols --setpref=layers.acceleration.force-enabled=disabled reftest/tests/layout/reftests/reftest.list

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1305314653.1305315310.4284.gz&fulltext=1

Do we want to add this test suite to the try server and mozilla-central?
Would that do? If more branches than that I would prefer devs to consent on the Tuesday development meeting because we would be adding more load where we are overloaded.
Attachment #532334 - Flags: review?(lsblakk)
Attachment #532336 - Flags: review?(lsblakk)
Attachment #532336 - Flags: feedback?(matt.woodrow+bugzilla)
Comment on attachment 532334 [details] [diff] [review]
[configs] add non accelerated reftests for linux

i'll update trychooser to add this new suite.
Attachment #532334 - Flags: review?(lsblakk) → review+
Attachment #532336 - Flags: review?(lsblakk) → review+
Matt we are ready to land whenever you are.
If you want me I can land this as soon as I hear from you.
Comment on attachment 532336 [details] [diff] [review]
[custom] add opengl-non-accel suite

Looks great to me!
Attachment #532336 - Flags: feedback?(matt.woodrow+bugzilla) → feedback+
This has been enabled on production.
Thanks Armen. 

Do we need to do anything else for this new testsuite to show up on tbpl?
If it was actually running, and if the name it's showing to the world is "reftest-no-accel" then tbpl should show it as an Ru in the R() group on the Linux opt row. I don't see any sign that it's actually running, though.
*sigh* It seems that I missed to reconfigure the schedulling master.
I am doing that now.

I already had the feeling that something was not quite right yesterday but not enough time had passed to be sure about it.

I will make sure it shows on tbpl and report back.
I had to add scrapping on mozilla-central.

I missed again one of the scheduling masters (I have adjusted my scripts to avoid this from happening again).

I can't verify that it shows up on tbpl as I will soon be gone and I will be off tomorrow and Friday. I will check on Thursday unless philor beats me to it :D

Not sure if we will need a tbpl patch or not.
philor what is that Ru that you mention?
Summary: Enable OpenGL reftests for linux machines → Enable non-accelerated OpenGL reftests for Linux machines
Ru is what, according to the current pending and running builds, we'll be calling these. Probably left over from when we were turning on hwaccel on Windows, any test whose name matches /reftest-no-accel/i gets listed as Ru with the tooltip Reftest Unaccelerated.
I am glad I chose the same name for consistency :)

See you Thursday!
I had to add scrapping for Try and I see it running on mozilla-central.

Closing.

Note that this has not been enabled for other branches to try to save resources.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Do we want to enable reftest-no-accel for every branch like any other suites?
We have some fake extra capacity for some time and I would like more realistic load for when we get the next testing pool (hopefully in Q4/Q1).

see bug 677037.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.