648750 - "Not Spam" and "Message Read" icons should be different

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Attachment: Screenshot (Windows)

I sometimes want to mark a message as unread to come back to it later (e.g. reply), and I usually do that by clicking the small icon in the Read column. However, I've noticed that quite often instead of clicking on that icon, I click on the same icon in the Spam column, which means that not only the message is being automatically moved to the spam folder, but that bayesian filters are fed with incorrect info. This was really annoying until one day I realised what the cause of this nuisance is and hid the Spam column.

I suggest to change the "not spam" icon to something more unique in order to better differentiate it from the "Message Read" icon.

This applies to the default theme on all OS, thus I've set the OS to all.

Comment 1

[Jan D]

I totally agree – I assume this is a common problem and would probably be easy to fix. 

Usability Heuristics violated: "Consistency and standards", "Recognition rather than recall"

Comment 2

[Jan D]

Attachment: Proposed change to the standard theme’s inactive-spam icon of thunderbird

currently, the inactive "spam" and the inactive "viewed" indicator/button in the mail list look the same. Thus, users must check with the column head to know what a click on the icon does. This change would keep the information at the icon itself without adding visual noise (low contrast, like the inactive favorite-button)

Comment 3

[Jan D]

Would a solution like this (https://bugzilla.mozilla.org/attachment.cgi?id=8642085)  be acceptable? 
If there is a "pro" by more experienced community members, I could try to create a patch that modifies the theme to this. (if anybody more experienced in themes would pick this up that person would probably be much more efficient though)

Comment 4

[Magnus Melin [:mkmelin]]

Looks like a good idea to me. Richard?

Comment 5

[Richard Marti (:Paenglab)]

Yes, I like it too.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: spam-nospam.png

Blake, I have a patch adding the nospam icon. What do you think about it? Should I change something?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8669436 [details]
spam-nospam.png

I like it.  And I don't think I'ld change anything.  :)

Thanks!

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug648750.patch

Okay, here's the patch.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 8669441 [details] [diff] [review]
Bug648750.patch

Review of attachment 8669441 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 10

[Richard Marti (:Paenglab)]

Thank you.

Comment 11

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/646ce824a926a3bde26402b0296afa3b9dccc9e6
Bug 648750 - Use a own icon for "Not Spam" in message pane. ui-r=bwinton r=mkmelin