Last Comment Bug 648870 - Stop trying to package the tests in proxies/, since proxies/ doesn't exist
: Stop trying to package the tests in proxies/, since proxies/ doesn't exist
Status: RESOLVED FIXED
fixed-in-tracemonkey
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: ---
Assigned To: Phil Ringnalda (:philor)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-10 09:46 PDT by Phil Ringnalda (:philor)
Modified: 2011-04-12 00:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (533 bytes, patch)
2011-04-10 09:46 PDT, Phil Ringnalda (:philor)
bob: review+
Details | Diff | Splinter Review

Description Phil Ringnalda (:philor) 2011-04-10 09:46:57 PDT
Created attachment 524960 [details] [diff] [review]
fix

Every time we package up tests, we gather them all up, and then say

tar: proxies: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors

(and then move along happily, but I was using "No such file" to look for something else in logs, and finding it every single time a build packaged jstests gets in the way).
Comment 1 Bob Clary [:bc:] 2011-04-10 10:13:09 PDT
The change seems fine, but Andreas added that line in bug 546590 back in May 2010. Andreas, did we decide to not to include the proxy tests in this location? Any objection to removing it from the Makefile.in ?
Comment 2 Phil Ringnalda (:philor) 2011-04-10 10:24:47 PDT
Oh, I didn't expect the whole history to be visible from just the bug that added it to the makefile, that's way easier to trace than I expected.

http://hg.mozilla.org/tracemonkey/rev/4dd9be00049c landed everything, including the tests in proxies/, but forgot to package them up. http://hg.mozilla.org/tracemonkey/rev/83f38f7b4fc1 added proxies/ to the makefile, packaging them. http://hg.mozilla.org/tracemonkey/rev/67e1c38f60fd then moved them out of proxies/, into js1_8_5/extensions/, and just forgot to remove proxies/ from the makefile.
Comment 3 Bob Clary [:bc:] 2011-04-10 10:36:16 PDT
Comment on attachment 524960 [details] [diff] [review]
fix

cool.
Comment 4 Phil Ringnalda (:philor) 2011-04-10 13:38:50 PDT
http://hg.mozilla.org/tracemonkey/rev/d0c4ec536e5f
Comment 5 Chris Leary [:cdleary] (not checking bugmail) 2011-04-12 00:02:53 PDT
http://hg.mozilla.org/mozilla-central/rev/d0c4ec536e5f

Note You need to log in before you can comment on or make changes to this bug.