As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 648870 - Stop trying to package the tests in proxies/, since proxies/ doesn't exist
: Stop trying to package the tests in proxies/, since proxies/ doesn't exist
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: ---
Assigned To: Phil Ringnalda (:philor)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-04-10 09:46 PDT by Phil Ringnalda (:philor)
Modified: 2011-04-12 00:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (533 bytes, patch)
2011-04-10 09:46 PDT, Phil Ringnalda (:philor)
bob: review+
Details | Diff | Splinter Review

Description User image Phil Ringnalda (:philor) 2011-04-10 09:46:57 PDT
Created attachment 524960 [details] [diff] [review]

Every time we package up tests, we gather them all up, and then say

tar: proxies: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors

(and then move along happily, but I was using "No such file" to look for something else in logs, and finding it every single time a build packaged jstests gets in the way).
Comment 1 User image Bob Clary [:bc:] 2011-04-10 10:13:09 PDT
The change seems fine, but Andreas added that line in bug 546590 back in May 2010. Andreas, did we decide to not to include the proxy tests in this location? Any objection to removing it from the ?
Comment 2 User image Phil Ringnalda (:philor) 2011-04-10 10:24:47 PDT
Oh, I didn't expect the whole history to be visible from just the bug that added it to the makefile, that's way easier to trace than I expected. landed everything, including the tests in proxies/, but forgot to package them up. added proxies/ to the makefile, packaging them. then moved them out of proxies/, into js1_8_5/extensions/, and just forgot to remove proxies/ from the makefile.
Comment 3 User image Bob Clary [:bc:] 2011-04-10 10:36:16 PDT
Comment on attachment 524960 [details] [diff] [review]

Comment 4 User image Phil Ringnalda (:philor) 2011-04-10 13:38:50 PDT
Comment 5 User image Chris Leary [:cdleary] (not checking bugmail) 2011-04-12 00:02:53 PDT

Note You need to log in before you can comment on or make changes to this bug.