Last Comment Bug 648876 - Remove superfluous $(OS_ARCH) filter-outs from js/src/Makefile.in (bug 647389 follow-up)
: Remove superfluous $(OS_ARCH) filter-outs from js/src/Makefile.in (bug 647389...
Status: VERIFIED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla6
Assigned To: Ed Morley [:emorley]
:
:
Mentors:
Depends on:
Blocks: 647389
  Show dependency treegraph
 
Reported: 2011-04-10 10:20 PDT by Ed Morley [:emorley]
Modified: 2011-05-02 17:06 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (based on TM rev 4ace629bb676) (1.77 KB, patch)
2011-04-10 10:26 PDT, Ed Morley [:emorley]
jimb: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-04-10 10:20:51 PDT
Follow-up to bug 647389, which removed all instances of |WINCE| from js/src/Makefile.in

This left a few of:

> ifeq (,$(filter-out XXXXX,$(OS_ARCH)))
and
> ifneq (,$(filter-out XXXXX,$(OS_ARCH)))

...whereby XXXXX was just one platform; and as such is equivalent to:

> ifeq ($(OS_ARCH),XXXXX)
and
> ifneq ($(OS_ARCH),XXXXX)
Comment 1 Ed Morley [:emorley] 2011-04-10 10:26:21 PDT
Created attachment 524969 [details] [diff] [review]
Patch v1 (based on TM rev 4ace629bb676)
Comment 2 Jason Orendorff [:jorendorff] 2011-04-11 11:24:24 PDT
Shifting the review to jimb, who actually knows this language ;)
Comment 3 Ed Morley [:emorley] 2011-04-11 11:26:26 PDT
Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-)

Is there a list somewhere of who is best to ask for reviews? (Other than just looking at hg log)
Comment 4 Jim Blandy :jimb 2011-04-11 11:27:54 PDT
(In reply to comment #2)
> Shifting the review to jimb, who actually knows this language ;)

Oh, it's a very pleasant little stringy language! You'd *love* it!
Comment 5 Jim Blandy :jimb 2011-04-11 11:28:49 PDT
Comment on attachment 524969 [details] [diff] [review]
Patch v1 (based on TM rev 4ace629bb676)

Thanks for the cleanup!
Comment 6 Ed Morley [:emorley] 2011-04-11 11:32:43 PDT
(In reply to comment #5)
> Thanks for the cleanup!

No problem! Thanks for the speedy review :-)
Comment 7 Paul Biggar 2011-04-11 12:05:56 PDT
(In reply to comment #3)
> Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-)
> 
> Is there a list somewhere of who is best to ask for reviews? (Other than just
> looking at hg log)

hg log and blame work best, but there is also this list: https://wiki.mozilla.org/JavaScript:Hackers
Comment 8 Ed Morley [:emorley] 2011-04-13 13:18:42 PDT
(In reply to comment #7)
> hg log and blame work best, but there is also this list:
> https://wiki.mozilla.org/JavaScript:Hackers

Great, thanks!
Comment 10 Paul Biggar 2011-04-15 09:29:31 PDT
(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67

Just an FYI - changes in js/src/ should go into the tracemonkey tree. This should be fine this time though, no need for a backout or anything.
Comment 11 :Ehsan Akhgari 2011-04-15 15:29:58 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67
> 
> Just an FYI - changes in js/src/ should go into the tracemonkey tree. This
> should be fine this time though, no need for a backout or anything.

Sorry, I usually pay attention to not land js checkin-needed stuff, this one got through my list somehow...

Note You need to log in before you can comment on or make changes to this bug.