Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: Craig Topper)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

nsIImageFrame can be removed.  http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsIImageFrame.h
(Assignee)

Comment 1

6 years ago
Created attachment 529006 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
(Assignee)

Comment 2

6 years ago
Created attachment 529007 [details] [diff] [review]
Part 2: Remove nsIImageFrame
(Assignee)

Comment 3

6 years ago
Created attachment 529008 [details] [diff] [review]
Part 3: Remove nsIImageMap
(Assignee)

Updated

6 years ago
Attachment #529006 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #529007 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #529008 - Flags: review?(roc)
Comment on attachment 529006 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h

Review of attachment 529006 [details] [diff] [review]:

::: layout/generic/nsImageFrame.h
@@ +186,5 @@
   virtual void AddInlineMinWidth(nsRenderingContext *aRenderingContext,
                                  InlineMinWidthData *aData);
 
+  nsRefPtr<mozilla::layers::ImageContainer> GetContainer(mozilla::layers::LayerManager* aManager,
+                                                         imgIContainer* aImage);

Add "typedef mozilla::layers::ImageContainer ImageContainer;" etc to nsImageFrame to avoid cluttering the code with prefixes.
Attachment #529006 - Flags: review?(roc) → review+
Comment on attachment 529007 [details] [diff] [review]
Part 2: Remove nsIImageFrame

Review of attachment 529007 [details] [diff] [review]:
Attachment #529007 - Flags: review?(roc) → review+
Comment on attachment 529008 [details] [diff] [review]
Part 3: Remove nsIImageMap

Review of attachment 529008 [details] [diff] [review]:

::: accessible/src/html/nsHTMLImageMapAccessible.cpp
@@ +204,5 @@
   nsIFrame *frame = GetFrame();
   NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
   nsImageFrame *imageFrame = do_QueryFrame(frame);
 
+  nsRefPtr<nsImageMap> map = imageFrame->GetImageMap(presContext);

I think 'map' doesn't need to be an nsRefPtr, it can just be a raw ptr.
Attachment #529008 - Flags: review?(roc) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 529030 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
(Assignee)

Updated

6 years ago
Attachment #529006 - Attachment is obsolete: true
(Assignee)

Comment 8

6 years ago
Created attachment 529032 [details] [diff] [review]
Part 2: Remove nsIImageFrame
(Assignee)

Updated

6 years ago
Attachment #529007 - Attachment is obsolete: true
(Assignee)

Comment 9

6 years ago
Created attachment 529033 [details] [diff] [review]
Part 3: Remove nsIImageMap
(Assignee)

Updated

6 years ago
Attachment #529008 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Assignee: nobody → craig.topper
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 10

6 years ago
Comment on attachment 529030 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h

Carry forward r+
Attachment #529030 - Flags: review+
(Assignee)

Comment 11

6 years ago
Comment on attachment 529032 [details] [diff] [review]
Part 2: Remove nsIImageFrame

Carry forward r+
Attachment #529032 - Flags: review+
(Assignee)

Comment 12

6 years ago
Comment on attachment 529033 [details] [diff] [review]
Part 3: Remove nsIImageMap

Carry forward r+
Attachment #529033 - Flags: review+
(Assignee)

Comment 13

6 years ago
http://hg.mozilla.org/mozilla-central/rev/5377c9056437
http://hg.mozilla.org/mozilla-central/rev/04d191d85f50
http://hg.mozilla.org/mozilla-central/rev/4456506e9326
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.