Last Comment Bug 648885 - Remove nsIImageFrame
: Remove nsIImageFrame
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Craig Topper
:
Mentors:
Depends on:
Blocks: deCOM
  Show dependency treegraph
 
Reported: 2011-04-10 11:35 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2011-05-01 17:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Remove 'using namespace' from nsImageFrame.h (4.61 KB, patch)
2011-04-28 18:07 PDT, Craig Topper
roc: review+
Details | Diff | Review
Part 2: Remove nsIImageFrame (10.51 KB, patch)
2011-04-28 18:10 PDT, Craig Topper
roc: review+
Details | Diff | Review
Part 3: Remove nsIImageMap (9.94 KB, patch)
2011-04-28 18:10 PDT, Craig Topper
roc: review+
Details | Diff | Review
Part 1: Remove 'using namespace' from nsImageFrame.h (3.83 KB, patch)
2011-04-28 20:53 PDT, Craig Topper
craig.topper: review+
Details | Diff | Review
Part 2: Remove nsIImageFrame (10.67 KB, patch)
2011-04-28 20:54 PDT, Craig Topper
craig.topper: review+
Details | Diff | Review
Part 3: Remove nsIImageMap (9.93 KB, patch)
2011-04-28 20:55 PDT, Craig Topper
craig.topper: review+
Details | Diff | Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2011-04-10 11:35:03 PDT
nsIImageFrame can be removed.  http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsIImageFrame.h
Comment 1 Craig Topper 2011-04-28 18:07:20 PDT
Created attachment 529006 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
Comment 2 Craig Topper 2011-04-28 18:10:07 PDT
Created attachment 529007 [details] [diff] [review]
Part 2: Remove nsIImageFrame
Comment 3 Craig Topper 2011-04-28 18:10:23 PDT
Created attachment 529008 [details] [diff] [review]
Part 3: Remove nsIImageMap
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-04-28 19:26:13 PDT
Comment on attachment 529006 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h

Review of attachment 529006 [details] [diff] [review]:

::: layout/generic/nsImageFrame.h
@@ +186,5 @@
   virtual void AddInlineMinWidth(nsRenderingContext *aRenderingContext,
                                  InlineMinWidthData *aData);
 
+  nsRefPtr<mozilla::layers::ImageContainer> GetContainer(mozilla::layers::LayerManager* aManager,
+                                                         imgIContainer* aImage);

Add "typedef mozilla::layers::ImageContainer ImageContainer;" etc to nsImageFrame to avoid cluttering the code with prefixes.
Comment 5 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-04-28 19:29:51 PDT
Comment on attachment 529007 [details] [diff] [review]
Part 2: Remove nsIImageFrame

Review of attachment 529007 [details] [diff] [review]:
Comment 6 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-04-28 19:31:49 PDT
Comment on attachment 529008 [details] [diff] [review]
Part 3: Remove nsIImageMap

Review of attachment 529008 [details] [diff] [review]:

::: accessible/src/html/nsHTMLImageMapAccessible.cpp
@@ +204,5 @@
   nsIFrame *frame = GetFrame();
   NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
   nsImageFrame *imageFrame = do_QueryFrame(frame);
 
+  nsRefPtr<nsImageMap> map = imageFrame->GetImageMap(presContext);

I think 'map' doesn't need to be an nsRefPtr, it can just be a raw ptr.
Comment 7 Craig Topper 2011-04-28 20:53:49 PDT
Created attachment 529030 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h
Comment 8 Craig Topper 2011-04-28 20:54:33 PDT
Created attachment 529032 [details] [diff] [review]
Part 2: Remove nsIImageFrame
Comment 9 Craig Topper 2011-04-28 20:55:04 PDT
Created attachment 529033 [details] [diff] [review]
Part 3: Remove nsIImageMap
Comment 10 Craig Topper 2011-05-01 12:54:12 PDT
Comment on attachment 529030 [details] [diff] [review]
Part 1: Remove 'using namespace' from nsImageFrame.h

Carry forward r+
Comment 11 Craig Topper 2011-05-01 12:55:09 PDT
Comment on attachment 529032 [details] [diff] [review]
Part 2: Remove nsIImageFrame

Carry forward r+
Comment 12 Craig Topper 2011-05-01 12:55:35 PDT
Comment on attachment 529033 [details] [diff] [review]
Part 3: Remove nsIImageMap

Carry forward r+

Note You need to log in before you can comment on or make changes to this bug.