Make mochitest-ipcplugins make target lie like Tinderbox

RESOLVED FIXED in mozilla6

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

unspecified
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Tinderbox has a test suite named mochitest-ipcplugins, which sets dom.ipc.plugins.enabled=false and runs the tests in modules/plugin/test. Fine, I know the history behind that backward name, and expediency isn't just a habit with us, it's a matter of policy, and our motto.

So, you push something, and you break the mochitest-ipcplugins suite, so you back out and then try to repro locally, by running `make mochitest-ipcplugins`, which sets dom.ipc.plugins.enabled=true, exactly like `make mochitest` does, and runs the tests in modules/plugin/test. To your great surprise, you can't repro.
Attachment #524983 - Flags: review?(ted.mielczarek)
Assignee: nobody → philringnalda
Comment on attachment 524983 [details] [diff] [review]
Yeah, false, that's the ticket

lolololol

Also, I'd like to fix it someday so that the actual test commands that get run on tinderbox live in m-c somewhere, so that "make X" is exactly what happens on tinderbox.
Attachment #524983 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/b140e7746652
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.