Closed Bug 648904 Opened 13 years ago Closed 13 years ago

Bug 634218 breaks accessibility builds on Mac

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla6

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression, Whiteboard: [aurora-backout])

Attachments

(1 file)

Patch (v1)
1.38 KB, patch
surkov
: review+
Details | Diff | Splinter Review 
I wish we had at least a Tinderbox machine which built with accessibility enabled on Mac, and threw away the resulting build.  :(
Attached patch Patch (v1) — — Splinter Review 

        Attachment #524995 -
        Flags: review?(surkov.alexander)

        Attachment #524995 -
        Flags: review?(bolterbugz)

    
    

    
  
(In reply to comment #0)
> I wish we had at least a Tinderbox machine which built with accessibility
> enabled on Mac, and threw away the resulting build.  :(

that's bug 524775 sorry about the trouble.

    
    

    
  
Comment on attachment 524995 [details] [diff] [review]
Patch (v1)

r=me, thank you for doing this

        Attachment #524995 -
        Flags: review?(surkov.alexander)

        Attachment #524995 -
        Flags: review?(bolterbugz)

        Attachment #524995 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/55086e3bfe4d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2

    
    

    
  
Backed out of Aurora in the wake of the bug 634218 backout:
http://hg.mozilla.org/mozilla-aurora/rev/a98001afc510
Whiteboard: [aurora-backout]
Target Milestone: mozilla5 → mozilla6

    
    

    
  
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20100101 Firefox/6.0

The changes made to fix this issue are visible also in hg, under beta (i.e. return (mGeckoAccessible->State() & states::READONLY) == 0; in mozTextAccessible.mm)
Setting this as Verfied for Firefox 6 Beta.

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.