648916 - mobile builds need to use Mercurial build step

Status: RESOLVED DUPLICATE of bug 557260

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

Since mobile appeared to have been broken by something in a merge of a dozen csets, we tried to trigger two builds, a rebuild of one build on http://hg.mozilla.org/mozilla-central/rev/352ebc13e546 from before the bustage to see if that rev remained good, and a new whole build round on http://hg.mozilla.org/mozilla-central/rev/233dde6c5b44 from the middle of the merge.

Both just wound up giving us extra builds on the rev that was the tip of mozilla-central at the time.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 648918 comment 2 through bug 648918 comment 5 for a discussion of what seems like the likely cause here.

Comment 2

[Aki Sasaki (not active)]

Potential fixes:

a) Just replace the hg commandlines for the mozilla repo with a Mercurial build step. This may break some existing functionality -- force clobbers, potentially might not play well w/ scratchbox ?
b) Go with jhford's inherit-MercurialBuildFactory patch, which is still ~ >1week away. This can fix a lot, but is a fairly large change; I'm not sure how much this may break (the scope of what might break is most likely a superset of what would break in option a).
c) Migrate AndroidBuildFactory and MaemoBuildFactory fully to mozharness, and make sure whatever factory that calls it adds a --clobber and/or --revision based on properties/clobberer when needed.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to comment #2)
> Potential fixes:
> 
> a) Just replace the hg commandlines for the mozilla repo with a Mercurial build
> step. This may break some existing functionality -- force clobbers, potentially
> might not play well w/ scratchbox ?
> b) Go with jhford's inherit-MercurialBuildFactory patch, which is still ~
> >1week away. This can fix a lot, but is a fairly large change; I'm not sure how
> much this may break (the scope of what might break is most likely a superset of
> what would break in option a).
> c) Migrate AndroidBuildFactory and MaemoBuildFactory fully to mozharness, and
> make sure whatever factory that calls it adds a --clobber and/or --revision
> based on properties/clobberer when needed.

a) is going to be about as much work as b), imo.  I am going to be looking at the MercurialBuildFactory stuff later on today.

Comment 4

[Chris AtLee [:catlee]]

(In reply to comment #2)
> Potential fixes:
> 
> a) Just replace the hg commandlines for the mozilla repo with a Mercurial build
> step. This may break some existing functionality -- force clobbers, potentially
> might not play well w/ scratchbox ?
> b) Go with jhford's inherit-MercurialBuildFactory patch, which is still ~
> >1week away. This can fix a lot, but is a fairly large change; I'm not sure how
> much this may break (the scope of what might break is most likely a superset of
> what would break in option a).
> c) Migrate AndroidBuildFactory and MaemoBuildFactory fully to mozharness, and
> make sure whatever factory that calls it adds a --clobber and/or --revision
> based on properties/clobberer when needed.

d) use hgtool.py

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Going to do this as part of the mobile->mercurialbuildfactory work