Closed Bug 648943 Opened 9 years ago Closed 9 years ago

Make .childNodes actually use the wrapper cache

Categories

(Core :: XPConnect, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

Right now the code in quickstubs ends up not using it, because it's using nsIDOMNodeList, which does not inherit from nsWrapperCache.  But the actual type used by .childNodes does inherit from nsWrapperCache!
Attached patch The actual fixSplinter Review
Attachment #525033 - Flags: review?(peterv)
Attachment #525032 - Attachment is obsolete: true
Attachment #525032 - Flags: review?(peterv)
Priority: -- → P1
Whiteboard: [need review]
Comment on attachment 525033 [details] [diff] [review]
The actual fix

Just to be clear, we are using the wrapper cache but through a slower path (if we don't get it through a cast we QI at some point).
Attachment #525033 - Flags: review?(peterv) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/8a1136b1b624
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.