Make .childNodes actually use the wrapper cache

RESOLVED FIXED in mozilla5

Status

()

Core
XPConnect
P1
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({perf})

Trunk
mozilla5
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Right now the code in quickstubs ends up not using it, because it's using nsIDOMNodeList, which does not inherit from nsWrapperCache.  But the actual type used by .childNodes does inherit from nsWrapperCache!
Created attachment 525032 [details] [diff] [review]
Use the wrapper cache for childNodes in quickstubs.
Attachment #525032 - Flags: review?(peterv)
Created attachment 525033 [details] [diff] [review]
The actual fix
Attachment #525033 - Flags: review?(peterv)
Attachment #525032 - Attachment is obsolete: true
Attachment #525032 - Flags: review?(peterv)
Priority: -- → P1
Whiteboard: [need review]
Comment on attachment 525033 [details] [diff] [review]
The actual fix

Just to be clear, we are using the wrapper cache but through a slower path (if we don't get it through a cast we QI at some point).
Attachment #525033 - Flags: review?(peterv) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/8a1136b1b624
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.