649181 - Do not allow minVersion > maxVersion in install.rdf

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: install.rdf

steps to reproduce:
1. Upload an add-on which has minVersion > maxVersion in its install.rdf
example:
<Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>4.0.*</em:minVersion>
        <em:maxVersion>3.0.*</em:maxVersion>
</Description>


expected behavior:
Validation fails

observed behavior:
Validation is successful. See https://addons.allizom.org/en-US/firefox/addon/sunkjkjhh/

Comment 1

[Matt Basta [:basta]]

This is already in the validator and there are tests for it. One thing that could be making it fishy is if the list of versions the validator gets from zamboni is unordered. The list needs to be sorted from earliest to most recent. Can someone point out where the list is being generated/passed?

Comment 2

[Kumar McMillan [:kumar]]

The apps.json is generated by this command https://github.com/jbalogh/zamboni/blob/80cc09c5db23cfc2cfc5b52ffcd125b640454fb1/apps/applications/management/commands/dump_apps.py#L25 

And it is ordered by version.  However, zamboni's validator submodule was last updated on 4/12 so I'm updating it now.

Comment 3

[Matt Basta [:basta]]

Any word on whether that cleared up the issue?

Comment 4

[Matt Basta [:basta]]

This has the same issue as the bug that Kumar recently closed:

    <em:targetApplication>
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>4.0.*</em:minVersion>
        <em:maxVersion>3.0.*</em:maxVersion>
      </Description>
    </em:targetApplication>

4.0.* is not an earlier version than 3.0.*. The file should instead use:

    <em:targetApplication>
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>3.0.*</em:minVersion>
        <em:maxVersion>4.0.*</em:maxVersion>
      </Description>
    </em:targetApplication>

Comment 5

[Kumar McMillan [:kumar]]

(In reply to comment #0)
> observed behavior:
> Validation is successful. See
> https://addons.allizom.org/en-US/firefox/addon/sunkjkjhh/

Krupa, could you add a link to the actual validation that should have displayed the min > max error but did not?

Comment 6

[krupa raj[:krupa]]

I just uploaded an add-on  with min version = 3.6.* and max version = 3.1b3

Validation URL: https://addons.allizom.org/en-US/developers/upload/5c26959ed9fb469fa6cfdb8a6c122bfb

There is a warning about invalid versions range, but validation doesn't fail.

Comment 7

[Kumar McMillan [:kumar]]

ok, so this bug is to make min > max an error instead of just a warning?  I'll reopen since this is not a problem with the manifest itself.

Since Jorge is cc'd any opinions?  Is this something that should really block the user from submitting an addon.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #7)
> ok, so this bug is to make min > max an error instead of just a warning?  I'll
> reopen since this is not a problem with the manifest itself.
> 
> Since Jorge is cc'd any opinions?  Is this something that should really block
> the user from submitting an addon.

Yes, it should.

Comment 9

[Matt Basta [:basta]]

It's a really small change. Can someone take a quick look before I merge?

https://github.com/mozilla/amo-validator/pull/28

Comment 10

[Kumar McMillan [:kumar]]

looks good

Comment 11

[Matt Basta [:basta]]

Merged

https://github.com/mozilla/amo-validator/commit/abf3c30cbffa5a705b4f446dc5b64f228ae5c00e

Comment 12

[krupa raj[:krupa]]

This is not in zamboni yet

Comment 13

[Kumar McMillan [:kumar]]

This will land when preview updates to https://github.com/jbalogh/zamboni-lib/commit/77fa353

Comment 14

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/en-US/developers/upload/dbd3c99a4fcd4254800708bd139a6c2c

Comment 15

[krupa raj[:krupa]]

Attachment: post-fix screenshot