649191 - [traceback] 500 Internal Server Error trying to view poster in German locale (/de/)

Status: VERIFIED FIXED

(Websites :: spark.mozilla.org, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://spark.allizom.org/de/poster/zhulukid/spark-poster.pdf is triggering a traceback:

Traceback (most recent call last):

  File "/data/www/spark.allizom.org/spark_site/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/spark.allizom.org/spark_site/apps/poster/views.py", line 23, in userposter
    'ff_home_qr': url2qr('http://www.mozilla.com/mobile/home/')

  File "/data/www/spark.allizom.org/spark_site/apps/poster/utils.py", line 15, in render_to_pdf
    pdf = pisa.pisaDocument(StringIO.StringIO(html.content.encode("ISO-8859-1")), result)

  File "/data/www/spark.allizom.org/spark_site/vendor/lib/python/sx/pisa3/pisa_document.py", line 229, in pisaDocument
    raise Exception("Errors occured, please see log files for more informations")

Exception: Errors occured, please see log files for more informations

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Traceback (most recent call last):

  File "/data/www/spark.allizom.org/spark_site/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/spark.allizom.org/spark_site/apps/poster/views.py", line 23, in userposter
    'ff_home_qr': url2qr('http://www.mozilla.com/mobile/home/')

  File "/data/www/spark.allizom.org/spark_site/apps/poster/utils.py", line 15, in render_to_pdf
    pdf = pisa.pisaDocument(StringIO.StringIO(html.content.encode("ISO-8859-1")), result)

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 3911: ordinal not in range(128)

Comment 2

[Franck Lecollinet]

This should be fixed for all locales now. From my tests, both fr/ and de/ are working.

Commit:
https://github.com/mozilla/spark/commit/463ece7be9ec0fdff2b3f4634174ee780943a378

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on both https://spark.allizom.org/de/poster/zhulukid/spark-poster.pdf and https://spark.allizom.org/fr/poster/zhulukid/spark-poster.pdf

(There are some untranslated strings, particularly in the first paragraph, but I'm hoping that's covered elsewhere.)