649228 - [traceback] NameError: global name 'bleach' is not defined @ /z/en-US/firefox/blocked/i15

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/z/en-US/firefox/blocked/i15

traceback details:
Traceback (most recent call last):

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/blocklist/views.py", line 122, in blocked_detail
   {'item': item})

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
   rendered = render_to_string(request, template, context)

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
   return template.render(**get_context())

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/blocklist/templates/blocklist/blocked_detail.html", line 5, in top-level template code
   {% set details = item.details %}

 File "/data/amo_python/www/preview/zamboni/apps/blocklist/templates/blocklist/base.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 100, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 105, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/preview/zamboni/apps/blocklist/templates/blocklist/blocked_detail.html", line 13, in block "content"
   <h1>{{ _('<b>{0}</b> has been blocked for your protection.')|fe(details.name)|clean|nl2br }}</h1>

 File "/data/amo_python/www/preview/zamboni/apps/translations/helpers.py", line 69, in clean
   return clean_nl(bleach.clean(string)).strip()

NameError: global name 'bleach' is not defined

Comment 1

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/f627400

Comment 2

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/z/en-US/firefox/blocked/i15 and https://addons-next.allizom.org/z/en-US/firefox/blocked/i15