Closed Bug 649268 Opened 9 years ago Closed 9 years ago

msgReadSMIMEOverlay.xul: 1 s/observes/command/

Categories

(MailNews Core :: Security: S/MIME, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 11.0

People

(Reporter: sgautherie, Assigned: aceman)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files, 1 obsolete file)

See bug 613435 as an example.
Do you mean like this?
The other 2 line changes are trailing spaces removals.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #572308 - Flags: review?(sgautherie.bz)
Comment on attachment 572308 [details] [diff] [review]
change "observes" to "command"
[Checked in: Comment 3]

Neil's best to review this, though Serge can provide feedback if he wants.
Attachment #572308 - Flags: review?(sgautherie.bz)
Attachment #572308 - Flags: review?(neil)
Attachment #572308 - Flags: feedback?(sgautherie.bz)
Attachment #572308 - Flags: review?(neil) → review+
Keywords: checkin-needed
Attachment #572308 - Flags: feedback?(sgautherie.bz)
Checked in: http://hg.mozilla.org/comm-central/rev/543f0ca1555e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
TB file still needs this too.
Status: RESOLVED → REOPENED
Flags: in-testsuite-
Resolution: FIXED → ---
TB file? What is that?
(In reply to :aceman from comment #5)
> TB file? What is that?

See 'URL' field of this bug.
For the time being, /mailnews/ file is used by SeaMonkey, /mail/ file is used by Thunderbird.
Status: REOPENED → ASSIGNED
Attached patch the same change, for Thunderbird (obsolete) — Splinter Review
Thanks, for the info, I am just learning the basics of the TB source tree.
I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB, /suite is for seamonkey. Is that not true?

Patch for TB attached.
Attachment #572907 - Flags: review?(neil)
Attachment #572907 - Flags: review?(neil) → review?(dbienvenu)
(In reply to :aceman from comment #7)

> I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB,
> /suite is for seamonkey. Is that not true?

You understood correctly.
But there are some exceptions in /mailnews, mostly when files were forked but not (yet) moved/unforked, like this one.

> Patch for TB attached.

Can you update the css line too, to keep both file in sync'?
Yes, I can look into it.
Comment on attachment 572907 [details] [diff] [review]
the same change, for Thunderbird

If Neil's happy so am I. Thanks.
Attachment #572907 - Flags: review?(dbienvenu) → review+
Should I make the css fix in a separate patch?
Ah, just update the patch with it in.
done
Attachment #572907 - Attachment is obsolete: true
Attachment #573574 - Flags: review?(mbanner)
Attachment #573574 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
Whiteboard: [good first bug] → [checkin the Thunderbird patch]
Checked in: http://hg.mozilla.org/comm-central/rev/aeb7f4dbcb2e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin the Thunderbird patch]
Attachment #572308 - Attachment description: change "observes" to "command" → change "observes" to "command" [Checked in: Comment 3]
Attachment #573574 - Attachment description: the same change, for Thunderbird + css line fix (trailing space) → the same change, for Thunderbird + css line fix (trailing space) [Checked in: Comment 14]
Target Milestone: Thunderbird 10.0 → Thunderbird 11.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.