Closed
Bug 649268
Opened 13 years ago
Closed 13 years ago
msgReadSMIMEOverlay.xul: 1 s/observes/command/
Categories
(MailNews Core :: Security: S/MIME, defect)
MailNews Core
Security: S/MIME
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird 11.0
People
(Reporter: sgautherie, Assigned: aceman)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files, 1 obsolete file)
2.17 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
1.66 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
See bug 613435 as an example.
Do you mean like this? The other 2 line changes are trailing spaces removals.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #572308 -
Flags: review?(sgautherie.bz)
Comment 2•13 years ago
|
||
Comment on attachment 572308 [details] [diff] [review] change "observes" to "command" [Checked in: Comment 3] Neil's best to review this, though Serge can provide feedback if he wants.
Attachment #572308 -
Flags: review?(sgautherie.bz)
Attachment #572308 -
Flags: review?(neil)
Attachment #572308 -
Flags: feedback?(sgautherie.bz)
Updated•13 years ago
|
Attachment #572308 -
Flags: review?(neil) → review+
Keywords: checkin-needed
Reporter | ||
Updated•13 years ago
|
Attachment #572308 -
Flags: feedback?(sgautherie.bz)
Comment 3•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/543f0ca1555e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Reporter | ||
Comment 4•13 years ago
|
||
TB file still needs this too.
Status: RESOLVED → REOPENED
Flags: in-testsuite-
Resolution: FIXED → ---
Reporter | ||
Comment 6•13 years ago
|
||
(In reply to :aceman from comment #5) > TB file? What is that? See 'URL' field of this bug. For the time being, /mailnews/ file is used by SeaMonkey, /mail/ file is used by Thunderbird.
Status: REOPENED → ASSIGNED
Thanks, for the info, I am just learning the basics of the TB source tree. I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB, /suite is for seamonkey. Is that not true? Patch for TB attached.
Attachment #572907 -
Flags: review?(neil)
Attachment #572907 -
Flags: review?(neil) → review?(dbienvenu)
Reporter | ||
Comment 8•13 years ago
|
||
(In reply to :aceman from comment #7) > I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB, > /suite is for seamonkey. Is that not true? You understood correctly. But there are some exceptions in /mailnews, mostly when files were forked but not (yet) moved/unforked, like this one. > Patch for TB attached. Can you update the css line too, to keep both file in sync'?
Comment 10•13 years ago
|
||
Comment on attachment 572907 [details] [diff] [review] the same change, for Thunderbird If Neil's happy so am I. Thanks.
Attachment #572907 -
Flags: review?(dbienvenu) → review+
Assignee | ||
Comment 11•13 years ago
|
||
Should I make the css fix in a separate patch?
Comment 12•13 years ago
|
||
Ah, just update the patch with it in.
Assignee | ||
Comment 13•13 years ago
|
||
done
Attachment #572907 -
Attachment is obsolete: true
Attachment #573574 -
Flags: review?(mbanner)
Updated•13 years ago
|
Attachment #573574 -
Flags: review?(mbanner) → review+
Keywords: checkin-needed
Whiteboard: [good first bug] → [checkin the Thunderbird patch]
Comment 14•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/aeb7f4dbcb2e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin the Thunderbird patch]
Reporter | ||
Updated•13 years ago
|
Attachment #572308 -
Attachment description: change "observes" to "command" → change "observes" to "command"
[Checked in: Comment 3]
Reporter | ||
Updated•13 years ago
|
Attachment #573574 -
Attachment description: the same change, for Thunderbird + css line fix (trailing space) → the same change, for Thunderbird + css line fix (trailing space)
[Checked in: Comment 14]
Reporter | ||
Updated•13 years ago
|
Target Milestone: Thunderbird 10.0 → Thunderbird 11.0
You need to log in
before you can comment on or make changes to this bug.
Description
•