Last Comment Bug 649268 - msgReadSMIMEOverlay.xul: 1 s/observes/command/
: msgReadSMIMEOverlay.xul: 1 s/observes/command/
Status: VERIFIED FIXED
:
Product: MailNews Core
Classification: Components
Component: Security: S/MIME (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 11.0
Assigned To: :aceman
:
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 621861
  Show dependency treegraph
 
Reported: 2011-04-12 02:27 PDT by Serge Gautherie (:sgautherie)
Modified: 2011-11-21 11:30 PST (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
change "observes" to "command" [Checked in: Comment 3] (2.17 KB, patch)
2011-11-06 09:44 PST, :aceman
neil: review+
Details | Diff | Splinter Review
the same change, for Thunderbird (761 bytes, patch)
2011-11-08 11:09 PST, :aceman
standard8: review+
Details | Diff | Splinter Review
the same change, for Thunderbird + css line fix (trailing space) [Checked in: Comment 14] (1.66 KB, patch)
2011-11-10 11:17 PST, :aceman
standard8: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-04-12 02:27:33 PDT
See bug 613435 as an example.
Comment 1 :aceman 2011-11-06 09:44:20 PST
Created attachment 572308 [details] [diff] [review]
change "observes" to "command"
[Checked in: Comment 3]

Do you mean like this?
The other 2 line changes are trailing spaces removals.
Comment 2 Mark Banner (:standard8, limited time in Dec) 2011-11-07 01:20:54 PST
Comment on attachment 572308 [details] [diff] [review]
change "observes" to "command"
[Checked in: Comment 3]

Neil's best to review this, though Serge can provide feedback if he wants.
Comment 3 Mark Banner (:standard8, limited time in Dec) 2011-11-08 03:54:16 PST
Checked in: http://hg.mozilla.org/comm-central/rev/543f0ca1555e
Comment 4 Serge Gautherie (:sgautherie) 2011-11-08 07:08:08 PST
TB file still needs this too.
Comment 5 :aceman 2011-11-08 08:03:56 PST
TB file? What is that?
Comment 6 Serge Gautherie (:sgautherie) 2011-11-08 09:15:18 PST
(In reply to :aceman from comment #5)
> TB file? What is that?

See 'URL' field of this bug.
For the time being, /mailnews/ file is used by SeaMonkey, /mail/ file is used by Thunderbird.
Comment 7 :aceman 2011-11-08 11:09:14 PST
Created attachment 572907 [details] [diff] [review]
the same change, for Thunderbird

Thanks, for the info, I am just learning the basics of the TB source tree.
I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB, /suite is for seamonkey. Is that not true?

Patch for TB attached.
Comment 8 Serge Gautherie (:sgautherie) 2011-11-08 15:04:40 PST
(In reply to :aceman from comment #7)

> I thought /mailnews is for "mailnews core" (shared parts), /mail is for TB,
> /suite is for seamonkey. Is that not true?

You understood correctly.
But there are some exceptions in /mailnews, mostly when files were forked but not (yet) moved/unforked, like this one.

> Patch for TB attached.

Can you update the css line too, to keep both file in sync'?
Comment 9 :aceman 2011-11-09 00:23:45 PST
Yes, I can look into it.
Comment 10 Mark Banner (:standard8, limited time in Dec) 2011-11-10 00:15:23 PST
Comment on attachment 572907 [details] [diff] [review]
the same change, for Thunderbird

If Neil's happy so am I. Thanks.
Comment 11 :aceman 2011-11-10 00:23:09 PST
Should I make the css fix in a separate patch?
Comment 12 Mark Banner (:standard8, limited time in Dec) 2011-11-10 00:46:56 PST
Ah, just update the patch with it in.
Comment 13 :aceman 2011-11-10 11:17:24 PST
Created attachment 573574 [details] [diff] [review]
the same change, for Thunderbird + css line fix (trailing space)
[Checked in: Comment 14]

done
Comment 14 Mark Banner (:standard8, limited time in Dec) 2011-11-15 02:34:11 PST
Checked in: http://hg.mozilla.org/comm-central/rev/aeb7f4dbcb2e

Note You need to log in before you can comment on or make changes to this bug.