Remove "Alpha #" from blank window titles for Nightly and Aurora

VERIFIED FIXED in Firefox 5

Status

()

Firefox
General
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: christian, Unassigned)

Tracking

unspecified
Firefox 5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

6 years ago
Aurora blank windows have "Alpha 2" in the title. Aurora will always have [version]a2 as its version. We should remove the "Alpha 2"
(Reporter)

Comment 1

6 years ago
Created attachment 525410 [details]
Alpha 2 in the title
(Reporter)

Comment 2

6 years ago
Possibly in http://mxr.mozilla.org/mozilla-central/source/config/printprereleasesuffix.py
(Reporter)

Updated

6 years ago
Blocks: 648368
No longer blocks: 48368
My understanding from #developers is that the actual summary should be "Drop the whole PRE_RELEASE_SUFFIX thing."

mozilla-central will always be n.0a1, never pre, and never released or branded, so a screenshot with "Nightly" in the titlebar can't be confused with anything; mozilla-aurora will always be n.0a2, never pre, never branded, and we're fine with having no way to tell the difference between a screenshot of a shipped Aurora and a tinderbox-build Aurora; mozilla-beta will always be n.0, never pre, always branded, and we're fine with having no way to tell the difference between a screenshot of the very first tinderbox-build from mozilla-beta and the final release of Firefox n.0.
(Reporter)

Comment 4

6 years ago
Correct.
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#115 is what does the conversion, I believe.
Yeah, I would have missed that, since it's probably the one place that doesn't use PRE_RELEASE_SUFFIX.

Also, http://mxr.mozilla.org/comm-central/source/mozilla/browser/installer/windows/nsis/defines.nsi.in#37 - do we want Aurora Windows installs to find and clobber a Firefox install? How about Beta?
Summary: Aurora blank windows have "Alpha 2" in the title → Remove PRE_RELEASE_SUFFIX
(Reporter)

Comment 7

6 years ago
Adding Mayumi, my understanding is that is what we want.

Comment 8

6 years ago
Yes, for Aurora, Beta and Release, whatever the user downloads most recently trumps the existing install e.g., if I install Aurora and I already have Firefox 4 then Aurora replaces Firefox 4.  Then when the Beta comes out and I download Beta then it replaces Aurora.
(Reporter)

Comment 9

6 years ago
Created attachment 525615 [details] [diff] [review]
Wallpaper patch that kills "Alpha #" from the window title

tryserver builds can be found at http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/clegnitto@mozilla.com-8868b8ea1454/tryserver-macosx64/.

The issue happens on both m-c and m-a.
(Reporter)

Comment 10

6 years ago
Created attachment 525622 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string
Attachment #525615 - Attachment is obsolete: true
Attachment #525622 - Flags: review?
(Reporter)

Updated

6 years ago
Attachment #525622 - Flags: review? → review?(robert.bugzilla)
Comment on attachment 525622 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string

I believe the package-name.mk is still necessary.

You also need to do
http://mxr.mozilla.org/mozilla-central/source/browser/base/Makefile.in#65
Attachment #525622 - Flags: review?(robert.bugzilla) → review-
(Reporter)

Comment 12

6 years ago
Created attachment 525630 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string

Ok, searched in mxr this time.
Attachment #525622 - Attachment is obsolete: true
(Reporter)

Updated

6 years ago
Attachment #525630 - Flags: review?(robert.bugzilla)
Comment on attachment 525630 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string

This is good for now for the installer and in app strings. Still need the package-name.mk changes as stated in comment #11.
Attachment #525630 - Flags: review?(robert.bugzilla) → review+
(Reporter)

Comment 14

6 years ago
Created attachment 525632 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string, v4
Attachment #525630 - Attachment is obsolete: true
Attachment #525632 - Flags: review?(robert.bugzilla)
Comment on attachment 525632 [details] [diff] [review]
Wallpaper over PRE_RELEASE_SUFFIX by setting it to the empty string, v4

This looks fine!

releng should be given a heads up about the name changing
Attachment #525632 - Flags: review?(robert.bugzilla) → review+
(Reporter)

Comment 16

6 years ago
CC'd.
(Reporter)

Comment 17

6 years ago
Wallpaper pushed to m-c in http://hg.mozilla.org/mozilla-central/rev/5542d52a4832. If green, I'll push to aurora.
(Reporter)

Comment 18

6 years ago
Also pushed to mozilla-aurora: 
   http://hg.mozilla.org/mozilla-aurora/rev/0e4308feb597
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Blocks: 649587
(Reporter)

Updated

6 years ago
Summary: Remove PRE_RELEASE_SUFFIX → Remove "Alpha #" from blank window titles for Nightly and Aurora
Target Milestone: --- → Firefox 5

Comment 19

6 years ago
Works For Me on the following builds:

Win7: 
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1
Mozilla/5.0 (Windows NT 6.1; rv:5.0a2) Gecko/20110421 Firefox/5.0a2

Win XP:
Mozilla/5.0 (Windows NT 5.1; rv:5.0a2) Gecko/20110421 Firefox/5.0a2 
Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 

Linux:
Mozilla/5.0 (X11; Linux i686; rv:6.0a1) Gecko/20110421 Firefox/6.0a1
Mozilla/5.0 (X11; Linux i686; rv:5.0a2) Gecko/20110421 Firefox/5.0a2

Mac 10.6:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110421 Firefox/5.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110421 Firefox/6.0a1

Setting resolution to Verified
Status: RESOLVED → VERIFIED

Updated

6 years ago
Blocks: 657882

Updated

6 years ago
Blocks: 658083

Updated

6 years ago
Blocks: 658227
Depends on: 663841
Blocks: 943733
You need to log in before you can comment on or make changes to this bug.