649485 - create complete MARs for all builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

bug 649322 tracks an issue that with mar generation logic that broke all l10n nightly builds on trunk, in the update portion. This got me thinking that it would be easy for something to break complete MAR generation on en-US, too. We should start generating MARs for dep builds, to catch these sorts of things earlier.

Ideally, we shouldn't upload them, though. We'll want something in the build system to help us here, or to just throw them out before running upload. This isn't a blocker, though.

Comment 1

[[e-mail] (:bhearsum)]

This might be something we do as part of CI build promotion.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Yes indeed.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

So I don't have to figure this out again:
* mozharness builds call 'mach build'
* that does a normal 'make -f client.mk', then conditional on MOZ_AUTOMATION does 'make automation/build' (see python/mozbuild/mozbuild/mach_commands.py)
* that call will run one or more targets defined in build/moz-automation.mk, which in turn depend on variables like MOZ_AUTOMATION_UPDATE_PACKAGING
* defaults for those variables are in build/mozconfig.automation, with overrides depending on IS_NIGHTLY (which is set by buildbot), eg build/unix/mozconfig.linux

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [gecko] Do some nightly work on dep builds

Generates a complete mar by default, but not a partial. Uploads crash symbols by default. This lets us do a release build on every push, but defer partials to funsize. In theory anyway, testing it on date.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [gecko] Do some nightly work on dep builds, wip v2

Debug builds were hitting errors uploading symbols, so this just changes release style builds. Should also fixes the if which can disable partial update generation.

Known issue - post_upload.py discards the complete mar because it thinks it's dealing with a tinderbox-build. We still get it uploaded to Taskcluster/S3 though (but behind auth).

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Not working on release promotion at the moment, releasing bug.

Comment 7

[Aki Sasaki (not active)]

We create complete mars for all shippable builds.