649513 - Failing to load stats_worker.js

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P2)

Description

[Wil Clouser [:clouserw]]

When I try to view a stats page, eg. https://addons.mozilla.org/z/en-US/firefox/addon/status-watch/statistics/ The bottom three graphs never stop spinning.  My error console says:

Error: Failed to load script: https://static.addons.mozilla.net/media/js/zamboni/stats/stats_worker.js (nsresult = 0x805303f4)

Comment 1

[Potch [:potch]]

The script is failing to load because workers must be loaded from same-origin. I've moved stats_worker.js to media/js/workers/. Possible solutions here are setting up the headers so the CDN is treated as same-origin (might not be wise) or exempting media/js/workers from a CDN rewrite (might be kludgey). Wil, what do you think?

Comment 2

[Wil Clouser [:clouserw]]

I don't like either of those! :)

It sounds like a special case either way, not rewriting the script is probably the best.  If you give me the new URL, I'll get that added

Comment 3

[Potch [:potch]]

The script is at /media/js/workers/stats_worker.js

I made the workers directory, so we can actually exempt all future workers with a slightly more general rule if we so wish.

Comment 4

[Wil Clouser [:clouserw]]

That's a good idea.  We can just use this bug.  Oremj, can you add this to the exclusions so it doesn't hit the CDN?

  ^/media/js/workers/.*

A similar rule was added in bug 649789

Comment 5

[Jeremy Orem [:oremj]]

Added this to preview: 

   RewriteCond %{ENV:REQ_URI} ^/media/js/workers/.*$
    RewriteRule . - [E=IS_CDN_REQ:false]

Comment 6

[Wil Clouser [:clouserw]]

Cool, I'm getting a different error now, so I think this is fixed.  Thanks.

Comment 7

[krupa raj[:krupa]]

Filed bug 655833 for the new JS error.

I don't see the error anymore @ https://addons.allizom.org/z/en-US/firefox/addon/status-watch/statistics/?last=90

Marking this as verified.