649528 - File read functionality should support binary files

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[/\/\arcio Galli]

This is an enhancement request to the require("file") API: 

packages/api-utils/lib/file.js

The use case is when the developer wants to read a file that is provided in binary form and not the textual form. Currently the read only supports text mode.

Comment 1

[/\/\arcio Galli]

https://github.com/mozilla/addon-sdk/pull/142#

Comment 2

[Drew Willcoxon :adw]

Thanks for the patch.  I made some comments on the pull request.  r+ with those addressed.

Comment 3

[/\/\arcio Galli]

@Drew, thanks for the review. My updates: 

doc: https://github.com/taboca/addon-sdk/commit/f0dc39419b5772c018d5453c79bf57243b30fa3a

code: https://github.com/taboca/addon-sdk/commit/cf80e62240df42105afbf07253143914749f616e

Comment 4

[Drew Willcoxon :adw]

Thanks again Marcio.  Landed:

Marcio's commits:

https://github.com/mozilla/addon-sdk/commit/6e5d6f0c1a2453916c5a48ef62618499cab8756f

https://github.com/mozilla/addon-sdk/commit/e9c7cc19da848504091678c82f8633deee2dec5c

https://github.com/mozilla/addon-sdk/commit/cf80e62240df42105afbf07253143914749f616e

https://github.com/mozilla/addon-sdk/commit/f0dc39419b5772c018d5453c79bf57243b30fa3a

My merge of Marcio's branch and master:

https://github.com/mozilla/addon-sdk/commit/a1e5fcccdbd91832f98f742eb95a853d6bcb4c40

My follow-ups:

https://github.com/mozilla/addon-sdk/commit/58d0134f16f36fd2373c2ad85c79f3a6824204c9

https://github.com/mozilla/addon-sdk/commit/62d2710ef37db495f748777149556118ce423075

My merge of my repo and master, or something:

https://github.com/mozilla/addon-sdk/commit/8489f02b349358c0e0005e288eb3da939227634b