Last Comment Bug 649531 - tidy up this-computation logic a bit, add some asserts (b/c #jsapi told me to)
: tidy up this-computation logic a bit, add some asserts (b/c #jsapi told me to)
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Luke Wagner [:luke]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-04-12 17:09 PDT by Luke Wagner [:luke]
Modified: 2011-04-26 15:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (71 bytes, patch)
2011-04-12 17:09 PDT, Luke Wagner [:luke]
no flags Details | Diff | Splinter Review
this time qref'd (20.88 KB, patch)
2011-04-14 13:16 PDT, Luke Wagner [:luke]
jwalden+bmo: review+
Details | Diff | Splinter Review

Description User image Luke Wagner [:luke] 2011-04-12 17:09:08 PDT
Created attachment 525564 [details] [diff] [review]

This patch factors out some prep work for bug 644074.

0. Inline ComputeGlobalThis into its only caller
1. Split CallArgs into CallReceiver and CallArgs to capture/remove the uses of 'vp' where we don't have/care about argv.
2. Assert call.callee() isn't used after call.rval()
3. Change JSStackFrame::computeThis into a free function since isn't a simple accessor/mutator of a stack frame; its an effectful interpreter operation akin to ComputeImplicitThis/GetPrimitiveThis/BoxNonStrictThis.  Put it next to these functions.
4. Reunite GetPrimitiveThis and details::PrimitiveBehavior
Comment 1 User image Luke Wagner [:luke] 2011-04-14 13:16:09 PDT
Created attachment 526092 [details] [diff] [review]
this time qref'd
Comment 2 User image Luke Wagner [:luke] 2011-04-14 20:58:09 PDT
Comment 3 User image Chris Leary [:cdleary] (not checking bugmail) 2011-04-26 15:18:41 PDT

Note You need to log in before you can comment on or make changes to this bug.