The default bug view has changed. See this FAQ.

tidy up this-computation logic a bit, add some asserts (b/c #jsapi told me to)

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 525564 [details] [diff] [review]
patch

This patch factors out some prep work for bug 644074.

0. Inline ComputeGlobalThis into its only caller
1. Split CallArgs into CallReceiver and CallArgs to capture/remove the uses of 'vp' where we don't have/care about argv.
2. Assert call.callee() isn't used after call.rval()
3. Change JSStackFrame::computeThis into a free function since isn't a simple accessor/mutator of a stack frame; its an effectful interpreter operation akin to ComputeImplicitThis/GetPrimitiveThis/BoxNonStrictThis.  Put it next to these functions.
4. Reunite GetPrimitiveThis and details::PrimitiveBehavior
Attachment #525564 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 1

6 years ago
Created attachment 526092 [details] [diff] [review]
this time qref'd
Attachment #525564 - Attachment is obsolete: true
Attachment #525564 - Flags: review?(jwalden+bmo)
Attachment #526092 - Flags: review?(jwalden+bmo)
Attachment #526092 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/tracemonkey/rev/e06d53aec568
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/e06d53aec568
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.