64954 - filter ui bugs

Status: VERIFIED WORKSFORME

(MailNews Core :: Filters, defect)

Description

[(not reading, please use [e-mail] instead)]

feel free to break this apart into several bugs.  some of them are probably
duplicates of existing filter bugs.

1) preflight the server picker in the filters dialog to the currently selected
server.  we appear to preflight to the default account server.

2) the list of server should be the same order as the folder pane, and should
have icons.

3) we should have a checkbox, and not the the read / unread green dot, for the
enabled column.  and it should be centered in the "Enabled" column.

4) sender, not subject, should be first rule.  sender filters are more common
than subject filters, right?

5) addition rules (if you hit more) should behave like 4.x.

6) first rule should not be prefaced "or the" or "and then".  only the 2nd, 3rd,
etc should have that.

7) the "ALL / ONE" radio buttons are not level, and they texts for the buttons
switch heights when clicked.

Comment 1

[laurel]

Some info:

Item #1 is covered by bug 41715.
Item #2 may be related to/dependent upon bug 17476.
Item #4:  I don't particularly care one way or another and wouldn't want to be
on the most common usage, but some historical info: Subject is listed as first
criteria choice in 4.x (win32). I remember from Nova/Dogbert days that John
Friend specified this order, whereas it originally was Sender first.
Item #5:  could you be a little more specific?
Item #6 was generally covered under bug 40356

Other ui items may be covered in a "filter ui polish" kind of bug -- there are a
few out there which were also written up to cover several general items at once.

Comment 2

[(not reading, please use [e-mail] instead)]

> Item #4:  I don't particularly care one way or another and wouldn't want to be
> on the most common usage, but some historical info: Subject is listed as first
> criteria choice in 4.x (win32). I remember from Nova/Dogbert days that John
> Friend specified this order, whereas it originally was Sender first.

4.x linux has sender as first.

> Item #5:  could you be a little more specific?

Sorry.  With 4.x, the first rule was sender and the following rules were Subject.

first rule, Sender.
(hit More), second rule Subject.
(hit More), third rule Subject.

thanks for finding the bugs that are associated with my list.

filters, as with most of the mailnews UI, needs some polish.

this would be a low priority bug for the next release, I just wanted to get
those problems into bugzilla.

Comment 3

[Håkan Waara]

Sounds like a bug well-suited for me (althought, at this point, I don't know how
one could fix #5).. if it's ok with you Seth.

Adding ui and polish keywords.

Comment 4

[(not reading, please use [e-mail] instead)]

hwaara, any contributions are welcome.

Comment 5

[laurel]

More background info:
About item #4: Mac 4.x DOES use subject first.
About item #5: Neither 4.x Mac nor 4.x Win32 does the switch to another criter
default on More like 4.x unix.
As usual, comparing to 4.x is not uniform across the platforms.

Comment 6

[Håkan Waara]

So what should we do here? Is the previous comment a suggestion for making this
a WONTFIX?

Comment 7

[jglick]

#4 I think either Subject or Sender are a good choice for the default. These are 
probably the most commonly used. I don't think one or the other is a better 
choice.  But since both Mac and Windows had Subject, maybe we should go with 
that.

#5 Similar here. One behavior isn't really better than the other. Again, i'd go 
with the Mac/Windows behavior since that is probably the biggest group of users.

Some other UI related filter bugs:
45038 - Filter Rules Dialog: General Clean up. 
45034 - Message Filters Dialog UI: General Cleanup.
62106 - Feature: double-click filter doesn't open for editing.
Adding mnemonics to these dialogs is also needed but a low priority.

Comment 8

[scottputterman]

reassigning to naving

Comment 9

[Håkan Waara]

As jglick mentions, the defaults for #4 and #5 doesn't really matter.

This bug is somewhat content-less now. If there are any remaining nits that are
not taken care of yet, please file new bugs.

Marking as worksforme.

Comment 10

[laurel]

Marking verified worksforme to close this one out.