649634 - [ACR] Compat Reporter doesn't support today's nightly version (Firefox 6.0a1, SeaMonkey 2.2a1pre)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Daniel Holbert [:dholbert]]

Today's mozilla-central nightly user agent string is:
Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110413 Firefox/6.0a1

Add-on compat reporter supports "Firefox 3.5 - 4.2a1pre"

Comment 2

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110413 Firefox/6.0a1 SeaMonkey/2.2a1pre ID:20110413023002

Yeah, it also boasts support of Sm 2.0 to 2.1b2 but AFAICT it works just as well with trunk builds of SeaMonkey like this one. I've recently used it on itself (after disabling compatibility auto-disables so it would start, of course).

Comment 3

[Daniel Holbert [:dholbert]]

I think that technically deserves its own bug, but I'll leave that up to the ACR devs.  (maybe it's a trivial enough fix that it doesn't matter.)

Comment 4

[Justin Scott [:fligtar]]

I've bumped the compatibility up to 6.0a1 but we should make sure all of the prefs are there too. Brian, can you add support for Firefox 5, 6, 7, and 8?

This should cover alphas and final release, e.g. 6.0a and 6.0. I'll probably make this patch myself later today if you're not around.

Comment 5

[Brian King [:kinger]]

I can fix SM as well here. What versions should be added?

Comment 6

[Brian King [:kinger]]

5.0a, 5.0b, 5.0pre and 5.0p are already there. So just to clarify, what needs to be added is:

- 6.0
- 6.0a
- 7.0
- 7.0a
- 7.0
- 7.0a

??

Comment 7

[Tony Mechelynck [:tonymec]]

(In reply to comment #5)
> I can fix SM as well here. What versions should be added?

Adding a couple of CC to the guys which I think know best about this question.

Comment 8

[Daniel Holbert [:dholbert]]

Hmm, bad news -- it looks like ACR might not actually _work_ in today's nightly, even after the version bump...

If I fire up a fresh profile, install ACR, restart, and then try to install e.g. FoxyProxy Basic (which worked fine for me in yesterday's nightly w/ ACR), I get:
> FoxyProxy Basic could not be installed because it is not compatible with Nightly 6.0a1

And in my normal profile, with ACR now re-enabled post-version-bump, all of my previously-flagged-as-working addons are now disabled (and have no option to force compatibility.

Comment 10

[Justin Scott [:fligtar]]

Brian, those versions are right for Firefox. The latest version on AMO for SeaMonkey is 2.2a1pre so I'd say make sure we support all versions of 2.2 for it but anything else should be a separate bug. We need to get the update out ASAP.

Comment 11

[Justin Wood (:Callek)]

(In reply to comment #10)
> Brian, those versions are right for Firefox. The latest version on AMO for
> SeaMonkey is 2.2a1pre so I'd say make sure we support all versions of 2.2 for
> it but anything else should be a separate bug. We need to get the update out
> ASAP.

That sounds right for SeaMonkey at this time anyway, yes. [sorry for the delay]

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Justin, so is the checkin which has been made by Brian already enough and I can test the build he has sent out, or is more stuff to do? Due to Brian is in India he will not read the messages in the next couple of hours.

Comment 13

[Scott Turner]

Attachment: Patched Add-On Compatibility Reporter

Adds 6.0, 7.0 support.  To add additional versions, edit chrome/content/modules/constants.jsm

Comment 14

[Justin Scott [:fligtar]]

Attachment: updated acr

Here's an updated build with Firefox and Seamonkey for QA. The only changes since previous version should be http://viewvc.svn.mozilla.org/vc?view=revision&revision=87300

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The link to the repository does not include changes for Thunderbird. Mark, do we have to update the compatibility prefs for Thunderbird too?

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #15)
> The link to the repository does not include changes for Thunderbird. Mark, do
> we have to update the compatibility prefs for Thunderbird too?

Comment 17

[Justin Scott [:fligtar]]

We need to push this now; we're not waiting for any other apps.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The XPI works fine with:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110413 Firefox/6.0a1

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110413 Firefox/6.0a1

We are good to release this bit.

Comment 19

[Justin Scott [:fligtar]]

Alright, the update has been pushed live. Thanks everyone!

Please file separate bugs for any other issues.

Comment 20

[Valdis Kletnieks]

Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110413 Firefox/6.0a1 ID:20110413090934

Also good here.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with installation from AMO.

Comment 22

[Daniel Holbert [:dholbert]]

(In reply to comment #8)
> Hmm, bad news -- it looks like ACR might not actually _work_ in today's
> nightly, even after the version bump...

Just to follow up on this earlier comment -- with the most recent ACR update, it works now.