Closed Bug 649651 Opened 15 years ago Closed 15 years ago

Boost popup reopens after refreshing the dashboard page

Categories

(Websites :: spark.mozilla.org, defect)

Product:
Websites
Component:
spark.mozilla.org
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: guillaume, Assigned: franck.bugzilla)

Details

This issue has been reported by TBG. Here's the bug report: "I created a new account and immediately boosted, which should have earned me the "On Location" and "Parent Trap" badges, but when I successfully exited the overlay and landed on the page, I still had the "You haven't earned any badges" message and those challenges hadn't cleared. I hit the reload button to see if that would cause the badges to appear, and it did, but it also re-triggered the "Boost Your Spark" pop-up, even though I already had Boosted, as you can clearly see in the screen-grab below. I would categorize these bugs as critical — it makes the initial experience really confusing."
Assignee: nobody → franck.bugzilla
Target Milestone: --- → 1.1
A commit [1] for this landed after code freeze [2]; there's no way QA can reasonably test this fix and regression-test around it, and still expect to ship tomorrow -- can we either A) back this out, or B) move the release date? [1] https://github.com/mozilla/spark/commit/8ec99ceab696f74392c1a359c2aa45bb284febef [2] "-Tuesday 4/12: Code Freeze by 9AM PDT" from email
Even if this doesn't make it in time for 1.1, I think I need to explain my fix anyway: 1. The issue of the Boost popup appearing again on page refresh is now fixed. Before, the popup appeared when a special querystring parameter was found in the URL, which has now been replaced by a cookie (indicating that the user just registered). The cookie is cleared when the user loads the logged-in homepage. Consequently, the popup will never show up automatically again. Commit: https://github.com/mozilla/spark/commit/8ec99ceab696f74392c1a359c2aa45bb284febef 2. I will file another bug for milestone 1.2 about the issue of badges/challenges not refreshing.
Marking this bug as resolved and fixed for 1.2 as per comment 1.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: 1.1 → 1.2
verified fixed http://spark.allizom.org
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.