The default bug view has changed. See this FAQ.

allow MOZ_APP_NAME to be set by configure

RESOLVED FIXED in Firefox 6

Status

()

Firefox
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jhford, Assigned: jhford)

Tracking

Trunk
Firefox 6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

It would be nice to be able to set MOZ_APP_NAME in the mozconfig to avoid filesystem collisions.  My specific use case is packaging Firefox in an RPM.

I have been running a copy of firefox for a long time on my linux machines with this patch and --with-app-name=minefield for a couple weeks with no adverse effects.
Attachment #525742 - Flags: review?(ted.mielczarek)
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

Not really sold on the benefits, but I'm not morally opposed to it either.
Attachment #525742 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

Oh, I forgot one thing.

>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>+if test ! -z "$WITH_APP_NAME" ; then

I believe we more often write this as "if test -n "$WITH_APP_NAME";".
Created attachment 526327 [details] [diff] [review]
hg changeset

Nits addressed, uploaded in mercurial changeset format.
Created attachment 526332 [details] [diff] [review]
correct hg changeset

X11 redirection is hard, lets go shopping.
Attachment #526327 - Attachment is obsolete: true
Thanks!

http://hg.mozilla.org/mozilla-central/rev/bee1149208a9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.