Last Comment Bug 649722 - allow MOZ_APP_NAME to be set by configure
: allow MOZ_APP_NAME to be set by configure
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 6
Assigned To: John Ford [:jhford]
:
Mentors:
Depends on:
Blocks: 649721
  Show dependency treegraph
 
Reported: 2011-04-13 11:33 PDT by John Ford [:jhford]
Modified: 2011-04-16 05:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
set MOZ_APP_NAME (496 bytes, patch)
2011-04-13 11:33 PDT, John Ford [:jhford]
ted: review+
Details | Diff | Review
hg changeset (496 bytes, patch)
2011-04-15 11:40 PDT, John Ford [:jhford]
no flags Details | Diff | Review
correct hg changeset (750 bytes, patch)
2011-04-15 11:55 PDT, John Ford [:jhford]
no flags Details | Diff | Review

Description John Ford [:jhford] 2011-04-13 11:33:24 PDT
Created attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

It would be nice to be able to set MOZ_APP_NAME in the mozconfig to avoid filesystem collisions.  My specific use case is packaging Firefox in an RPM.

I have been running a copy of firefox for a long time on my linux machines with this patch and --with-app-name=minefield for a couple weeks with no adverse effects.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2011-04-15 11:18:49 PDT
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

Not really sold on the benefits, but I'm not morally opposed to it either.
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-04-15 11:19:27 PDT
Comment on attachment 525742 [details] [diff] [review]
set MOZ_APP_NAME

Oh, I forgot one thing.

>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>+if test ! -z "$WITH_APP_NAME" ; then

I believe we more often write this as "if test -n "$WITH_APP_NAME";".
Comment 3 John Ford [:jhford] 2011-04-15 11:40:20 PDT
Created attachment 526327 [details] [diff] [review]
hg changeset

Nits addressed, uploaded in mercurial changeset format.
Comment 4 John Ford [:jhford] 2011-04-15 11:55:37 PDT
Created attachment 526332 [details] [diff] [review]
correct hg changeset

X11 redirection is hard, lets go shopping.

Note You need to log in before you can comment on or make changes to this bug.