649738 - Contacts API needs unified interface for paging through contacts

Status: RESOLVED WONTFIX

(Cloud Services :: Server: Share, defect)

Description

[James Burke [:jrburke]]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

Right now each service has different arguments they use to page through the APIs. Ideally the share API call would just have one kind of paging args for the web client to use.

This may be difficult: the Gmail one may return an URL to use to call for the next set, whereas the twitter one uses a cursor model?

Depending on how this shakes out, another bug may need to be opened against the web client to implement the modified call. Allowing older cached web client UIs should be considered too.

Reproducible: Always

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

We need at least the twitter contacts issues fixed to get the twitter client finalized (bug 647578) so setting this as blocking that even though we could possibly fix the twitter issue without fixing the grater API issue.

Comment 2

[Shane Caraveo (:mixedpuppy)]

I have this working, you need to get the bug/649738-contactspaging branch in both mozilla/server-share-core and mozilla/f1 if you want to give it a spin

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Pointer to pull request

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Pointer to pull request

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 527396 [details]
Pointer to pull request

RaFromBRC to review python portion of pull request, jrburke for web content part.

Comment 6

[Shane Caraveo (:mixedpuppy)]

pushed server-share-core
https://github.com/mozilla/server-share-core/commit/95f89f9ec6e4130e4847af05ddab5b4309876af1

pushed f1/develop
https://github.com/mozilla/f1/commit/4382b8349f8a5874002e3251d1bc793758ce3731

Comment 7

[Shane Caraveo (:mixedpuppy)]

reopening to get tests for paged contacts

Comment 8

[Shane Caraveo (:mixedpuppy)]

closing server bugs, moving to client side.