649817 - file browser 500 error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Description

[David Chan [:dchan]]

I uploaded a file with unicode paths, then attempted to browse it at the above URL. The file extraction didn't finish after a couple minutes so I reloaded the page and got the Oops error.

STR
1. Visit above URL

Expected
No error

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Traceback (most recent call last):

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/preview/zamboni/apps/files/decorators.py", line 38, in wrapper
    return func(request, FileViewer(file), *args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/files/views.py", line 59, in files_list
    response = jingo.render(request, 'files/viewer.html', data)

  File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
    rendered = render_to_string(request, template, context)

  File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
    return template.render(**get_context())

  File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/amo_python/www/preview/zamboni/apps/files/templates/files/viewer.html", line 1, in top-level template code
    {% extends "files/base.html" %}

  File "/data/amo_python/www/preview/zamboni/apps/files/templates/files/base.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/amo_python/www/preview/zamboni/templates/base.html", line 108, in top-level template code
    {% block main_content %}

  File "/data/amo_python/www/preview/zamboni/templates/base.html", line 113, in block "main_content"
    {% block content %}{% endblock %}

  File "/data/amo_python/www/preview/zamboni/apps/files/templates/files/viewer.html", line 21, in block "content"
    data-short="{{ value['short'] }}"

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe1 in position 0: ordinal not in range(128)

I think this might be a dupe?

Comment 2

[Wil Clouser [:clouserw]]

Can you attach the add-on here?

Comment 3

[David Chan [:dchan]]

Attachment: xpi with utf path

There is extra data in the archive, I didn't bother reducing the test case. The two problemetic entries show up as
삮삮삯
삮삮삯etc삯passwd
in my terminal

Comment 4

[Andy McKay]

Also coped with long file names in the file listing.

https://github.com/jbalogh/zamboni/commit/c44df820dde355f4ea29f2172fd37b5ca32bdea9

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

David, is this fixed?  Mind verifying on allizom?  Thanks!

Comment 6

[David Chan [:dchan]]

Appears to work on allizom now

https://addons.allizom.org/z/en-US/firefox/files/browse/116655/

Closing out as VERIFIED