The default bug view has changed. See this FAQ.

refactor DeviceManager to allow multiple underlying implementations

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 526005 [details] [diff] [review]
WIP patch
(Assignee)

Updated

6 years ago
Blocks: 650205
Created attachment 530753 [details] [diff] [review]
patch

this changes how you initialize the devicemanager, but does not change runtestsremote.py to do it right (the patch in bug 650205 does that). So if these land separately there will have to be additional changes to make things work.
Assignee: nobody → blassey.bugs
Attachment #526005 - Attachment is obsolete: true
Attachment #530753 - Flags: review?(ctalbert)
this patch applied directly to a m-c tree has 7/8 hunks failed to apply.
oops, I downloaded and applied the wrong patch, the latest patch works just fine
I ran this with the patch from bug 650205 and I passed all my devicemanager unit tests (using SUT agent) as well as a handful of reftest and mochitest runs.  

In looking at this patch I don't see anything that throws up red flags.

Comment 6

6 years ago
Comment on attachment 530753 [details] [diff] [review]
patch

This looks great. Thanks Blassey.  I like the way you created pure virutal methods in the DeviceManager class.

r+

Joel, I can get the patch together to push this to remotetesting/ and droidfarm/.  Do you want to do the talos one?
Attachment #530753 - Flags: review?(ctalbert) → review+
once this lands on m-c, I will do the talos patch.
http://hg.mozilla.org/mozilla-central/rev/8ad0dfefa6fa
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.