649825 - refactor DeviceManager to allow multiple underlying implementations

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: WIP patch

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

this changes how you initialize the devicemanager, but does not change runtestsremote.py to do it right (the patch in bug 650205 does that). So if these land separately there will have to be additional changes to make things work.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this patch applied directly to a m-c tree has 7/8 hunks failed to apply.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

oops, I downloaded and applied the wrong patch, the latest patch works just fine

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I ran this with the patch from bug 650205 and I passed all my devicemanager unit tests (using SUT agent) as well as a handful of reftest and mochitest runs.  

In looking at this patch I don't see anything that throws up red flags.

Comment 6

[cmtalbert]

Comment on attachment 530753 [details] [diff] [review]
patch

This looks great. Thanks Blassey.  I like the way you created pure virutal methods in the DeviceManager class.

r+

Joel, I can get the patch together to push this to remotetesting/ and droidfarm/.  Do you want to do the talos one?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

once this lands on m-c, I will do the talos patch.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/mozilla-central/rev/8ad0dfefa6fa