Closed Bug 649825 Opened 10 years ago Closed 10 years ago
Manager to allow multiple underlying implementations
No description provided.
this changes how you initialize the devicemanager, but does not change runtestsremote.py to do it right (the patch in bug 650205 does that). So if these land separately there will have to be additional changes to make things work.
this patch applied directly to a m-c tree has 7/8 hunks failed to apply.
oops, I downloaded and applied the wrong patch, the latest patch works just fine
I ran this with the patch from bug 650205 and I passed all my devicemanager unit tests (using SUT agent) as well as a handful of reftest and mochitest runs. In looking at this patch I don't see anything that throws up red flags.
Comment on attachment 530753 [details] [diff] [review] patch This looks great. Thanks Blassey. I like the way you created pure virutal methods in the DeviceManager class. r+ Joel, I can get the patch together to push this to remotetesting/ and droidfarm/. Do you want to do the talos one?
Attachment #530753 - Flags: review?(ctalbert) → review+
once this lands on m-c, I will do the talos patch.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.