Closed Bug 649830 Opened 9 years ago Closed 9 years ago

SeaMonkey 2.1pre (Polish) for Mac contains Russian or Swedish language packs

Categories

(SeaMonkey :: Build Config, defect)

x86
macOS
defect
Not set

Tracking

(blocking-seamonkey2.1 final+)

RESOLVED FIXED
seamonkey2.1final
Tracking Status
blocking-seamonkey2.1 --- final+

People

(Reporter: adriank, Assigned: Callek)

References

Details

Attachments

(1 file, 1 obsolete file)

Todays (13.04.2011) Polish SeaMonkey 2.1pre for Mac contains Russian language packs for ChatZilla and Venkman. A build from a few days ago (iirc, April, 7th, 10th or 11th) contained Swedish language packs instead. Another build from the pas few days contained Russian language packs too.

The Polish language packs are always there, like they should be. The other language packs are there "just additionally".
Robert any chance you have a clue whats going on here?
blocking-seamonkey2.1: --- → ?
Sounds to me like things would not be cleaned up correctly between repacks, perhaps due to some repacks breaking?
(In reply to comment #0)
> Todays (13.04.2011) Polish SeaMonkey 2.1pre for Mac contains Russian language
> packs for ChatZilla and Venkman. A build from a few days ago (iirc, April, 7th,
> 10th or 11th) contained Swedish language packs instead. Another build from the
> pas few days contained Russian language packs too.
> 
> The Polish language packs are always there, like they should be. The other
> language packs are there "just additionally".

Adriank is this a problem with the release repacks (2.1b3, 2.0.14, etc.)?

I wonder if this is just a Nightly repack issue...
(In reply to comment #3)
> Adriank is this a problem with the release repacks (2.1b3, 2.0.14, etc.)?
> 
> I wonder if this is just a Nightly repack issue...

I didn't see it with the release repacks (2.1b3 & 2.0.13).

I think it maybe something KaiRo is talking about in Comment #2, especially as the wrong additional locale was not far away alphabetically from "pl" ("ru", "sv-SE"). But this would assume, that the repacks are done from z->a and not a->z (I don't know which way they are done actually).
ok, everything I can see about this seems to mean that it would never happen for a release.

It looks like this only happens on a failed repack (where the actual repack succeeds but extensions do not) and we then don't actually cleanup at the end like the script/tooling expects.

I CC-ed Pike incase he can offer any further thoughts/insights on this stuff. But my brief glancing seems to indicate that the easiest/best fix would be in the buildbot code.
blocking-seamonkey2.1: ? → -
This is inside the makefile stuff.

repackage-zip in l10n.mk depends on libs-$(AB_CD), and if that fails, it never ends up to call clobber-zip.

IMHO, the fix is to make the extension packs not fail. I think that they do is just fall out from lack of reporting elsewhere, not that I have a proposal on how to fix that.
The fix will be fairly risky, so I am marking wontfix for our 2.1 branch, but certainly wanted.
(In reply to comment #7)
> The fix will be fairly risky, so I am marking wontfix for our 2.1 branch,
> but certainly wanted.

Actually.... I see a slightly different issue than just the failing locale stuff (I'll fix that in a separate bug)

I just noticed that our 2.1rc1 updates/complete mars are including xpi's for other locale langpacks (I'll have to do a build2)

So this now blocks, patch coming soon
Assignee: nobody → bugspam.Callek
Blocks: SM2.1rc1
blocking-seamonkey2.1: - → final+
This should do it... 
plan for 2.1 |default|
         2.1 relbranch
         c-c


note the following output from a 2.1rc1 build of pl:


....
processing Contents/MacOS/distribution/extensions/inspector@mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ca@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ca@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-cs@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-de@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-de@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-es-ES@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-es-ES@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-fi@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-fr@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-fr@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-it@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-it@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ja-JP-mac@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ja-JP-mac@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-nb-NO@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-pl@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-pl@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-pt-PT@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ru@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-ru@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-sk@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-sv-SE@chatzilla.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/langpack-sv-SE@venkman.mozilla.org.xpi
processing Contents/MacOS/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
processing Contents/MacOS/distribution/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}.xpi

.....

make clobber-zip AB_CD=pl
rm -f /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/chrome/pl.jar \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/chrome/pl.manifest \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/defaults/pref/suite-l10n.js
rm -f -rf /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/searchplugins \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/dictionaries \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/defaults/profile \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/chrome/pl \
	  /builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/extensions/langpack-pl@*
/builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/mozilla/config/nsinstall -D ../../mozilla/dist/mac64/pl/
mv -f "../../mozilla/dist/l10n-stage/mac64/pl/SeaMonkey 2.1 RC 1.dmg" "/builds/slave/rel-comm-2.0-osx64-rpk/build/comm-2.0/suite/locales/../../mozilla/dist/mac64/pl/SeaMonkey 2.1 RC 1.dmg"
repackaging done
program finished with exit code 0
elapsedTime=63.279806
Attachment #531460 - Flags: review?(kairo)
Attachment #531460 - Flags: approval-seamonkey2.1?
Comment on attachment 531460 [details] [diff] [review]
remove distribution/extensions/... too

Review of attachment 531460 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that one nit fixed, please land on both trunk and branch - and sorry for not catching that with my patch for moving the extensions.

::: suite/locales/Makefile.in
@@ +266,5 @@
>  	  $(STAGEDIST)/dictionaries \
>  	  $(STAGEDIST)/defaults/profile \
>  	  $(STAGEDIST)/chrome/$(AB_CD) \
> +	  $(STAGEDIST)/extensions/langpack-$(AB_CD)@* \
> +      $(STAGEDIST)/distribution/extensions/langpack-$(AB_CD)@* \

Please use the same format as the line above, which is a tab plus spaces.
Attachment #531460 - Flags: review?(kairo)
Attachment #531460 - Flags: review+
Attachment #531460 - Flags: approval-seamonkey2.1?
Attachment #531460 - Flags: approval-seamonkey2.1+
Attached patch For CheckinSplinter Review
Attachment #531460 - Attachment is obsolete: true
http://hg.mozilla.org/comm-central/rev/a4209b15c186
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1final
You need to log in before you can comment on or make changes to this bug.