649884 - symbol cleanup script needs to be reworked to handle nightly builds without 'pre'

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

In the new versioning scheme, we dropped 'pre' from our nightly build version numbers. Unfortunately, the script that cleans up our Breakpad symbol store, in an attempt to only clean up nightly build symbols, will only delete symbol files whose version ends with 'pre'. This needs to be fixed or we will never clean up nightly symbols.

Christian: in the new setup, mozilla-central nightlies will always be "x.0a1", and aurora nightlies will always be "x.0a2", correct? I understand that beta builds will simply be "x.0" as well, but we're not producing nightly builds there, right? We'll simply produce "release candidate" type builds that are limited in number? I think this means that I can just switch the cleanup script to treat the a1 and a2 builds similarly to how it currently treats pre builds.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: fix cleanup script to handle new Nightly/Aurora builds

Sorry, this fell off my radar. This patch has two fixes:
1) Treat versions ending with "a1" and "a2" like "pre". This will handle the new Nightly/Aurora nightly builds. As a side effect we'll wind up deleting some old a1 and a2 symbols, but I don't think anyone cares.
2) Handle project builds slightly better. Right now we have things like "-linux64-tracemonkey-symbols.txt", and the script doesn't actually handle multi-part project branch names, so those builds get lumped in with the "-linux64-symbols.txt" builds. This fix will use anything before "-symbols.txt" as the project branch.

I'll attach the output of --dry-run on symbols_ffx shortly.

Comment 2

[LegNeato]

(In reply to comment #0)
> 
> Christian: in the new setup, mozilla-central nightlies will always be
> "x.0a1", and aurora nightlies will always be "x.0a2", correct?

Yep.

 I understand
> that beta builds will simply be "x.0" as well, but we're not producing
> nightly builds there, right? We'll simply produce "release candidate" type
> builds that are limited in number?

Yes, for now. Later we'll do "builds if there have been changes".

> I think this means that I can just switch
> the cleanup script to treat the a1 and a2 builds similarly to how it
> currently treats pre builds.

Yep, and looks like you already did this :-). Sorry, this bug got lost in my bugmail.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: output of --dry-run on ffx_symbols

This looks pretty sane to me from a once-over.

Comment 4

[(not currently active) Ted Mielczarek]

I filed bug 657348 on there being an awful lot of nightly builds FWIW. This is why we're cleaning up tracemonkey nightlies from the end of April, because there are 2 or more per day, and we only keep 30 nightly builds.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 532666 [details] [diff] [review]
fix cleanup script to handle new Nightly/Aurora builds

Looks fine to me.

Comment 6

[(not currently active) Ted Mielczarek]

Pushed to build/tools:
http://hg.mozilla.org/build/tools/rev/cf95a6b0ada7

Will file a bug to get IT to update the copy on dm-symbolpush01.