649947 - Requests for more information don't show up anymore in the item history

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

In the review page of add-on, performed request for more information don't show up anymore in the item history, so every editor who sees that information is missing will send the developer a request for more information. Furthermore, past review requests from pre-zamboni don't show up (bug 624033 says you killed discussions).

Comment 1

[Kris Maglione [:kmag]]

Yep. The emails are definitely sent out but the requests aren't shown in the review log. This is a major problem, since it means that developers are going to get several copies of the same info request from different editors (probably even from the same editor multiple times on occasion).

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Kris and I tested on allizom whete bug 649596 is fixed: Mail is sent, but no info request in the item history.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Then the original bug should be reopened.

Comment 5

[Andy McKay]

Confirmed, we don't log this in the item history, will add.

Comment 6

[Andy McKay]

Logging super review requests as well.

Comment 7

[Kris Maglione [:kmag]]

Jorge: I don't think this is related to bug 649596. That was a specific issue which prevented the info request from being submitted (which was fixed). This is about them not appearing in the review log.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #7)
> Jorge: I don't think this is related to bug 649596. That was a specific issue
> which prevented the info request from being submitted (which was fixed). This
> is about them not appearing in the review log.

Because of bug bug 649596 comment #1 I thought both issues were going to be addressed in it. My bad.

Comment 9

[Andy McKay]

Yeah I'd rather keep them seperate too. As noted added in logging for super reviews at the same time.

https://github.com/jbalogh/zamboni/commit/2226df0b53acd511235280d71092b17b59f03627

Comment 10

[krupa raj[:krupa]]

Filed bug 650434

verified @ https://addons.allizom.org/en-US/editors/review/763825?num=20
https://addons.allizom.org/en-US/editors/review/763825?num=17
https://addons.allizom.org/en-US/editors/review/763739?num=6

Comment 11

[krupa raj[:krupa]]

Attachment: post-fix screenshot