Closed Bug 649965 Opened 13 years ago Closed 13 years ago

elfhack fails to build with gcc 4.6 lto

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Remove inlines on Elf_*::swap functions
3.41 KB, patch
taras.mozilla
: review+
Details | Diff | Splinter Review 
As reported on gcc bugzilla: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45375#c65

In function `serialize':
/var/tmp/mozilla-central/build/unix/elfhack/elfxx.h:239: undefined reference to
`void Elf_Ehdr_Traits::swap<big_endian, Elf64_Ehdr,
serializable<Elf_Ehdr_Traits> >(serializable<Elf_Ehdr_Traits>&, Elf64_Ehdr&)'
/var/tmp/mozilla-central/build/unix/elfhack/elfxx.h:228: undefined reference to
`void Elf_Ehdr_Traits::swap<big_endian, Elf32_Ehdr,
serializable<Elf_Ehdr_Traits> >(serializable<Elf_Ehdr_Traits>&, Elf32_Ehdr&)'
collect2: ld returned 1 exit status
Attachment #525977 - Flags: review?(tglek)
Assignee: nobody → mh+mozilla
Attachment #525977 - Flags: review?(tglek) → review+
http://hg.mozilla.org/mozilla-central/rev/16035907f7ed
http://hg.mozilla.org/users/mh_glandium.org/elfhack/rev/8a8bbcd861ca
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I visually inspected the code changes. Marking as Verified Fixed as per bug 659997 - Comment 7.
Status: RESOLVED → VERIFIED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.