elfhack fails to build with gcc 4.6 lto

VERIFIED FIXED in mozilla7

Status

()

Core
Build Config
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla7
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 525977 [details] [diff] [review]
Remove inlines on Elf_*::swap functions

As reported on gcc bugzilla: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45375#c65

In function `serialize':
/var/tmp/mozilla-central/build/unix/elfhack/elfxx.h:239: undefined reference to
`void Elf_Ehdr_Traits::swap<big_endian, Elf64_Ehdr,
serializable<Elf_Ehdr_Traits> >(serializable<Elf_Ehdr_Traits>&, Elf64_Ehdr&)'
/var/tmp/mozilla-central/build/unix/elfhack/elfxx.h:228: undefined reference to
`void Elf_Ehdr_Traits::swap<big_endian, Elf32_Ehdr,
serializable<Elf_Ehdr_Traits> >(serializable<Elf_Ehdr_Traits>&, Elf32_Ehdr&)'
collect2: ld returned 1 exit status
Attachment #525977 - Flags: review?(tglek)
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla

Updated

6 years ago
Attachment #525977 - Flags: review?(tglek) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/mozilla-central/rev/16035907f7ed
http://hg.mozilla.org/users/mh_glandium.org/elfhack/rev/8a8bbcd861ca
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I visually inspected the code changes. Marking as Verified Fixed as per bug 659997 - Comment 7.
Status: RESOLVED → VERIFIED
Duplicate of this bug: 647458
You need to log in before you can comment on or make changes to this bug.